Add CodeQL #1885
Open
Add CodeQL #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[User Model] merge from main
* Update `ISingletonModelStore.get()` function to be `ISingletonModelStore.model` property * Rework the model store change event system to always fire, using tags to differentiate why changes occurred. * Add `SubscriptionModel.status` to capture the subscription status, for when retrieving push token fails for some reason. * Drive event callback when app killed during request notification permission activity.
…-model-event-rework [User Model] notification_types and model event rework
* Implement visual logging * Remove IInfluenceManager.addSessionData which is no longer required, as session influence is captured via outcome. * Ensure IAM repository is cleaned on startup. * Create dummy IAMManager when <4.4
* Move outcome calls over to new ISessionManager (OneSignal.session) * Add OneSignal.disableGMSMissingPrompt
… moved to config model. * Document IPreferencesService * Document ITime
…-todos [User Model] Visual logging and other TODOs
[User Model] Session Manager
* Move IAM/Notification/Location to their own gradle modules. AndroidManifest/proguard has now been split across the 4 modules. * Load modules dynamically using reflection within OneSignalImpl, falling back to "Misconfigured" versions if the modules weren't specified in the application. * Make internal classes required by a OS module no longer defined as `internal` (but keep in internal namespace).
[User Model] Modularize IAM/Notification/Location
* local ID -> remote ID now get changed directly against the model. There is no longer an in-memory translation, which did not work in the event of an app restart. Each operation now has a `translateId` method to drive updating their IDs. * Rename `CreateUserOperation` to be `LoginUserOperation` and now has the ability to "identity" an existing user as the user being logged in, rather than always upserting a new user. * Update `OperationRepo` and supporting executors to properly handle error conditions. * Update `IOperationRepo.execute` to be `enqueueAndWait` which supports the change in behavior,,execution of an operation always happens on the background thread and does *not* jump the queue. * Update operation executors to now ensure the model is in a correct state post-backend execution.
[User Model] New login process and operation repo updates
[User Model] Core Unit Tests
* Renamed/moved `iam` module to be `inAppMessages` module * Renamed/moved `notification` module to be `notifications` module * Renamed `sendOutcomes` to be `addOutcomes` * Renamed `setTags` to be `addTags` * Moved triggers to be within `inAppMessages` module
[User Model] Move and rename
* Add `TrackSessionStartOperation` * Update executor to count sessions refresh device metadata on `TrackSessionStartOperation`
[User Model] Track Session Start
* Use SubscriptionStatus enum for subscription status across the codebase. * IUserManager.subscriptions.push can no longer be null. If there isn't a push subscription a "dummy" one is now returned. * Add `fallbackToSettings` parameter for `ILocationManager.requestPermission` and `INotificationsManager.requestPermission` * Renamed `INotificationsManager.permissionsStatus` to `permission` and made it a simple Boolean. * Added `INotificationsManager.canRequestPermission` as a flag to indicate when permissions can be requested. * Added `ISubscription.addChangeHandler` to allow user to listen for changes to the subscription.
…ription-alignment [User model] notification/subscription alignment
* Changed `IDeviceService.deviceType` to return an enum rather than int * Added `EventProducer.fireOnMain` and `CallbackProducer.fireOnMain` for easy firing of callbacks on main thread.
[User Model] Minor cleanup
* Added various unit tests for notifications module * removed high level unittest module from solution
…tests [User Model] Notifications Unit Tests
* Rename from notification opened to notification clicked * Remove INotificationsManager.postNotification * Small notification bug fixes
[User Model] Notification Clicked Handler
* Implement `UserBackendService`, `IdentityBackendService`, and `SubscriptionBackendService` * Tweak `OutcomeEventsBackendService` to provide `subscriptionId`
|
Great catch @shepherd-l! Looks like this was accidentally added and unused so I removed it. |
nan-li
requested changes
Nov 2, 2023
jennantilla
force-pushed
the
add_codeql
branch
from
94afbbb
to
8f16b35
Compare
This reverts commit df534d5.
…xception Fix: Add synchronized blocks to prevent ConcurrentModificationException
Fix SDK Unit Test failing in GitHub Actions build test workflow
Update work-runtime dependency version
Update comment linting errors on PropertiesModelTests
General protection against exceptions that occur on a thread.
Release 5.0.4
jennantilla
force-pushed
the
add_codeql
branch
from
8f16b35
to
33b9cc5
Compare
jennantilla
force-pushed
the
add_codeql
branch
from
33b9cc5
to
2320ee5
Compare
Update onReceive methods to check for correct action before proceeding. This prevents potential risk of third-party applications to send explicit intents to this receiver to cause a denial of service.
jennantilla
force-pushed
the
add_codeql
branch
from
900bf00
to
48eb818
Compare
|
Oops, @jinliu9508 this work should eventually get merged (it became stagnant due to a build error). But I think it will be easier for me to just create a new PR once we update to main. |
|
Re-opening so we don't lose this, we can always refactor later. The deletion of the usermodel branch (now recovered) caused the PRs to close. |
jinliu9508
force-pushed
the
user-model/main
branch
3 times, most recently
from
2072eac
to
d73bfc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add the CodeQL GitHub security scanning action to this repository.
Details
Add the CodeQL GitHub security scanning action to the this repository. This action will run on PRs into user-model/main and main branches.
Motivation
Security scanning
Scope
Static analysis
Checklist
Overview
Testing
Final pass
This change is