Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to annotation targets describing paths concluding with a navigation property #269

Merged
merged 8 commits into from
Apr 18, 2024

Conversation

millicentachieng
Copy link
Collaborator

This PR:

  • Remove markdown links from property descriptions to add as annotations
  • Update regex to ensure paths with typecasts are properly added as annotation targets
  • Replaces line breaks with space in property descriptions
  • Correctly append API version to link annotations
  • Ensure functions/actions with parameters are properly identified and annotated
  • Change how paths concluding with a navigation property are added as annotation targets e.g. now microsoft.graph.GraphService/users/manager, before microsoft.graph.user/manager.

Copy link
Collaborator

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance there's a diff of the metadata generated with changes in the PR?

ApiDoctor.Publishing/CSDL/csdlwriter.cs Outdated Show resolved Hide resolved
ApiDoctor.Publishing/CSDL/csdlwriter.cs Show resolved Hide resolved
@millicentachieng
Copy link
Collaborator Author

millicentachieng commented Mar 27, 2024

@andrueastman See how the metadata will look like here.

image

@millicentachieng millicentachieng merged commit d419b9e into master Apr 18, 2024
5 checks passed
@millicentachieng millicentachieng deleted the miachien/update-annotations branch April 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants