Skip to content

Commit

Permalink
Properly handle key-value with colletions (#252)
Browse files Browse the repository at this point in the history
  • Loading branch information
millicentachieng authored Feb 2, 2024
1 parent 98713e6 commit 9ce27cb
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions ApiDoctor.Publishing/CSDL/csdlextensionmethods.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ namespace ApiDoctor.Publishing.CSDL
internal static class CsdlExtensionMethods
{
private static readonly Regex GuidRegex = new(@"[0-9a-f\-]{32,36}", RegexOptions.Compiled | RegexOptions.IgnoreCase);

private static readonly Regex FunctionParamsRegex = new(@",(?![^\[]*])", RegexOptions.Compiled | RegexOptions.IgnoreCase);
public static string RequestUriPathOnly(this MethodDefinition method, IssueLogger issues = null)
{
issues ??= new IssueLogger();
Expand Down Expand Up @@ -121,9 +123,9 @@ public static string RequestUriPathOnly(this MethodDefinition method, IssueLogge

private static string NormalizeFunctionParameters(string funcParams, IssueLogger issues)
{
// foo=bar, baz ='qux',x= 9
// foo=bar,baz='qux',x= 9,quux=['corge','grault']
var normalized = new StringBuilder();
var allParams = funcParams.Split(',');
var allParams = FunctionParamsRegex.Split(funcParams);
for (int i = 0; i < allParams.Length; i++)
{
var param = allParams[i].Trim();
Expand Down

0 comments on commit 9ce27cb

Please sign in to comment.