Fix \transn Boarder and Bump Version to 2.1.1 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadinaif
force-pushed
the
shadinaif-fix-transn-boarder
branch
from
56f8565 to
05b352f
Compare
shadinaif
changed the title
|
@OmarIthawi would you please review this 👼 |
|
Nice work, @shadinaif . I have verified locally that these changes fix the issues I was experiencing! I wonder if we should add these example equations to https://github.com/OmarIthawi/arabic-mathjax/blob/master/testcases/testcases.yml ? I don't know what your policy is on when to add new cases there.
|
OmarIthawi
approved these changes
Apr 9, 2019
shadinaif
force-pushed
the
shadinaif-fix-transn-boarder
branch
from
05b352f to
9d1c9b5
Compare
shadinaif
changed the title
shadinaif
force-pushed
the
shadinaif-fix-transn-boarder
branch
from
9d1c9b5 to
7dc0159
Compare
|
@OmarIthawi Thank you. Yes, this can be considered a patch. I have changed it to 2.1.1 |
OmarIthawi
approved these changes
Apr 9, 2019
|
@shadinaif @OmarIthawi Thank you! Could you |
|
Thank you @OmarIthawi The npm package has been published @barillax 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
\transnoperator is not creating its own reserved space. The effect of that can be seen in operations like:\sqrt{\transn{1.234}}\transn{1.234}\\\transn{1.234}This PR is intended to fix the issue using the CSS file. The result will be:
\sqrt{\transn{1.234}}\transn{1.234}\\\transn{1.234}Fixes #19