feat: new tx history layout #2072
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| } | ||
|
|
||
| export const useSelectedTabIndex = create<SelectedTabIndexStore>(set => ({ | ||
| selectedIndex: 0, | ||
| setSelectedIndex: (index: number) => set({ selectedIndex: index }), |
There was a problem hiding this comment.
I think it would be cleaner if we used a consistent way of switching tabs, instead of having setSelectedIndex and openTransactionHistory & renamed the hook to useMainContentTabs. Just throwing a suggestion out here, let me know what you think:
enum MainContentTabs {
Bridge = 0,
TransactionHistory = 1
}
export const useMainContentTabs = create(set => ({
selectedTab: MainContentTabs.Bridge,
openBridge: () => set({ selectedTab: MainContentTabs.Bridge }),
openTransactionHistory: () => set({ selectedTab: MainContentTabs.TransactionHistory })
)})There was a problem hiding this comment.
i like this, will add these
but we still need to keep the setSelectedIndex function to accept a number for Tab.Group to use at onChange
There was a problem hiding this comment.
We use it only in TransactionHistory.tsx now, not sure if it's worth having it in a separate hook?
| type MainContentTabStore = { | ||
| selectedTab: MainContentTabs | ||
| setSelectedTab: (index: MainContentTabs) => void | ||
| openBridge: () => void |
There was a problem hiding this comment.
Could we rename these to switchToBridge and switchToTransactionHistory to be consistent with what we have in E2E's? Plus it sounds better since we aren't opening any panel - just switching to it.
Closes FS-974