fix: fetch correct cctp history for contract wallets #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
reviewed
Nov 5, 2024
| export const useCCTPDeposits = ({ | ||
| walletAddress, | ||
| l1ChainId, | ||
| pageNumber, | ||
| pageSize, | ||
| enabled | ||
| }: fetchCctpParams) => { | ||
| const { isSmartContractWallet } = useAccountType() | ||
| const chainId = useChainId() |
There was a problem hiding this comment.
i think we want to avoid using useChainId() because it returns Ethereum for chains not in wagmi config?
fionnachan
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FS-969
Issue
User withdraws USDC via CCTP from L2 Safe to L1. Then they connect to the destination account and don't see the transaction in the history.
Current setup and why it doesn't work:
Currently we use
cctpTypeToFetchto determine what type of transfers we fetch:deposits,withdrawalsorall. In case of EOA we fetch all (and it's fine because EOA's address is the same on L1 and L2). However, when using SCW we fetch eitherdepositsorwithdrawals. The current flow for SCW is as follows:Now if user is connected to the parent chain, we only fetch deposits. Which means they won't see withdrawals to their account and won't be able to claim from this account.
Solution
To fix this, we need to fetch
allCCTP transfers for SCW as well, but we need to keep in mind that L1 and L2 addresses may not be the same. To cover this we filter out transactions that aren't user's transactions. We use the following logic for this:I. Fetching deposits
Show if sender === walletAddress
Show if receiver === walletAddress
II. Fetching withdrawals