Add support for filter option for proxies. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Beattie <[email protected]>
|
Hello, any chance that this PR might be accepted? |
tersmitten
reviewed
Sep 25, 2020
Signed-off-by: Mike Beattie <[email protected]>
mjbnz
force-pushed
the
add-filter-option
branch
from
f19a008
to
417cee3
Compare
tersmitten
reviewed
Nov 29, 2021
| @@ -23,6 +23,9 @@ backend {{ backend.name }} | |||
| {% if backend.cookie is defined %} | |||
| cookie {{ backend.cookie }} | |||
| {% endif %} | |||
| {% for filter in backend.filter | default([]) %} | |||
| filter {{ filter.name }}{{ filter.params is defined | ternary([''] + [filter.params], []) | join(' ') }} | |||
| {% endfor %} | |||
There was a problem hiding this comment.
We tend to use something like this:
{% for param in server.param | default([]) %} {{ param }}{% endfor %}
I find that a bit easier to read.
There was a problem hiding this comment.
As explained in another of my PR's (#113 ), Ansible has trim_blocks enabled, so that format requires the presence of an unexplained blank line after the conditional. the line I used above avoids that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simply add support for haproxy content filters to be specified.
I'm using this to create an spoe filter on a backend successfully.