Add serviceName to NFS StatefulSet #229
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2f9fc57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
liam-mackie
approved these changes
Jul 14, 2024
There was a problem hiding this comment.
LGTM! Thanks for adding an install test as well for the current version.
The only thing I'm not certain of is whether this now breaks installation via ArgoCD, since I'm not certain if argo works with lookup functions (see argoproj/argo-cd#5202)
|
Converting back to draft as we may not want to actually merge this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
StatefulSetwith a headless service, you are supposed to set thespec.serviceNamevalue. We weren't.However, once a stateful set is created, this value can't be modified.
Because the
serviceNamecan't be modified after creation (even on an upgrade), we only include the service name if the statefulset doesn't exist, or if the statefulset exists and the serviceName is defined.Not setting this value isn't a big issue because we don't have multiple replica's of the NFS pods