Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingress class name in ingress spec #47

Merged
merged 3 commits into from
May 15, 2024

Conversation

trennepohl
Copy link
Contributor

@trennepohl trennepohl commented Jan 15, 2023

What?

  • Add standard annotation for specifying the Ingress class name
  • Set ingressClassName field in the Ingress Object
  • Keep backwards compatibilty with the old annotation
  • Always drop kubernetes.io/ingress-class annotation

Why?

  • It's prefereable to use the Ingress object attribute instead of the annotation.
  • Kubernetes 1.25+ won't support ingressClassName and the annotation kubernetes.io/ingress.class to be set simultaneously

@jordo
Copy link

jordo commented May 7, 2024

thoughts on merging this? seeing a lot of 1 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead.

@danieloliveira079
Copy link
Contributor

I will have a look this weekend.

@danieloliveira079 danieloliveira079 merged commit a6807fb into main May 15, 2024
1 check passed
@danieloliveira079 danieloliveira079 deleted the ingress-class-name branch May 15, 2024 17:47
@jordo
Copy link

jordo commented May 15, 2024

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants