Merge pull request #57 from Octops/fix-tls-secretname-ingress

Fix TLS Secret Logic
Octops · Jan 4, 2024 · 3e8900c · 3e8900c
2 parents 53a482c + b4eea20
commit 3e8900c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -36,7 +36,7 @@ OCTOPS_BIN := bin/octops-controller
 
 IMAGE_REPO=octops/gameserver-ingress-controller
 DOCKER_IMAGE_TAG ?= octops/gameserver-ingress-controller:${VERSION}
-RELEASE_TAG=0.2.8
+RELEASE_TAG=0.2.9
 
 default: clean build
 

diff --git a/deploy/install.yaml b/deploy/install.yaml
@@ -69,7 +69,7 @@ spec:
     spec:
       serviceAccountName: octops-ingress-controller
       containers:
-        - image: octops/gameserver-ingress-controller:0.2.8 # Latest release
+        - image: octops/gameserver-ingress-controller:0.2.9 # Latest release
           name: controller
           ports:
             - containerPort: 30235

diff --git a/pkg/reconcilers/ingress_reconciler.go b/pkg/reconcilers/ingress_reconciler.go
@@ -55,7 +55,10 @@ func (r *IngressReconciler) reconcileNotFound(ctx context.Context, gs *agonesv1.
 		WithCustomAnnotationsTemplate(),
 		WithIngressRule(mode),
 		WithTLS(mode),
-		WithTLSCertIssuer(issuer),
+	}
+
+	if issuer != "" {
+		opts = append(opts, WithTLSCertIssuer(issuer))
 	}
 
 	ingress, err := newIngress(gs, opts...)