JOSS paper #76
JOSS paper #76
Conversation
|
Docs now fixed and more complete #77 |
|
Now I've compiled the draft I do think I need to make the figure font sizes larger |
|
It’s mostly the font sizes that are too small to easily read at 100% magnification. However, the way that the sub panels are arrange might make it difficult to increase the font size. It might be better to have all sub panels in a single column. Another small comment is that the time for the Kelp Growth in Figure 1 might be confusing since the axis label starts at t=0, but the kelp don’t actually start growing until near the end of the second year.
…On Mar 18, 2023 at 7:56 PM +0000, Jago Strong-Wright ***@***.***>, wrote:
Now I've compiled the draft I do think I need to make the figure font sizes larger
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
I think this is now finalised if everyone is happy? @johnryantaylor |
|
I'm happy. Could you perhaps resolve the conflicts in |
done |
|
I might have deleted a change you made to the sediment thing actually @navidcy ? |
|
Once we're done we need to delete the draft workflow before merging too |
| sediment.denitrification_params.E * log(k) ^ 2 + | ||
| sediment.denitrification_params.F * log(O₂) * log(k)) / (Cᵐⁱⁿ * day) |
There was a problem hiding this comment.
I thought not having k as variable here was crucial, no?
There was a problem hiding this comment.
oh now I see this is commented out code.
do we need commented code?
| sediment.anoxic_params.D * log(k) + | ||
| sediment.anoxic_params.E * log(O₂) * log(k) + |
There was a problem hiding this comment.
This is fixed in #138 not here (would be good to merge 138 soon)
Co-authored-by: johnryantaylor <[email protected]>
small edits to the description in the caption to Fig 1
To do:
[ ] Check I've not broken box models- examples double as tests