-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors to improve code clarity and make changing parameterisations easier #212
Conversation
So I had todo some horrible things to get this to work on GPU because it seems that |
I think there is a whole new level of abstraction we could do by changing the model to be discrete form, which will likely make this run more efficiently, as well as facilitate grouping the phytoplankton etc. as discussed above. |
I think there is still some room to make this more flexible, for example changing
nanophytoplankton
anddiatoms
to justphytoplankton
which is aNamedTuple
of phytoplankton classes, but then we need functions likeammonia_uptake(all_the_phytoplanktons)
. This would be useful for experimentation in the future with different things but I am not going to implement here as we just want a working version, and then when people want to experiment that can make these kind of changes.To do: