Hmw ct jsw/pisces #209
Merged
Hmw ct jsw/pisces #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This where we're leaving PISCES after the internship:
PISCES is currently a working and (hopefully) correct model. She can run with a timestep of >=50mins on standard box and column models.
What remains to be done:
Although sinking speed has been implemented, w_GOC is not yet depth dependent. Currently this is because of issues with setup_velocity_fields requiring the velocity fields to be a named tuple of scalars, or a velocity field itself. As I am not sure how velocity fields work, I have left this, but the function field in the way I had tried did not work.
Yearly maximum silicate, carbonate saturation ratio and dust deposition, have all been assigned temporary values but not implemented fully.
Length of day is currently set to 1.0. This would need to be changed to allow more accurate phytoplankton growth.
Latitude is currently set at -1. This also needs a proper input function, as although the Aumont Paper only needs a positive or negative value of latitude, to add correct length of day we would need latitude.
The Aumont Paper assumes a constant vertical diffusivity of 1.0. Jago mentioned that this is actually determined by Oceananigans and OceanBioME, so this would need to be corrected.
PISCES does not work with open_bottom = false. Don’t know if this must be addressed but for testing it probably should do.
Testing files for the model.
Fix the Calcite model according to TOP/PISCES/P4Z/p4zlys.F90, and https://bg.copernicus.org/articles/4/505/2007/bg-4-505-2007.pdf.
Box Model could be altered to be a slice at different z values. Currently only z = 0 is possible, even with the changing of the grid type.
Fix the air-sea CO2 flux in the Column Model.