Make BoxModels speedy again (+ introduce prescribed PAR)
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It has been pointed out to me that box models don't return auxiliary fields from |
jagoosw
changed the title
BoxModels speedy againBoxModels speedy again (+ introduce prescribed PAR)
chloeyhuang
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to make time stepping better (~10x speedup for time stepping part) and a new "output writer" (but don't have time to make it an actual
AbstractOutputWriterat the moment) which is >10x faster for the really long file saving stage, resulting in ~30x speedup overall for outputting every 20 iterations.