Added invalid_fill_value to ScaleNegativeTracers
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al tracer content is less than 0
navidcy
approved these changes
Mar 25, 2024
src/Utils/negative_tracers.jl
Outdated
Comment on lines
67
to
68
| `invalid_fill_value` specifies the value to set the total cell content to if the total is less than 0 | ||
| (meaning that total tracer conservation can not be enforced). |
There was a problem hiding this comment.
perhaps we elaborate a bit more here... eg mention the caveat you included in the first comment in the PR? also, if other models follow similar practice perhaps mention 1-2 here?
|
Thanks for sorting @navidcy, I'm going to bump the patch number and they merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a parameter
invalid_fill_valuetoScaleNegativeTracersso that when the total cell content is less than 0 it doesn't have to be filled with NaNs. While even less ideal this seems to be the easiest way to keep complex models positive (e.g. the near global model), and is akin to how lots of earth system models do it.