Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.9.1) Move testing and docs to buildkite (+ minor GPU bug fix) #159

Merged
merged 10 commits into from
Nov 15, 2023

Conversation

jagoosw
Copy link
Collaborator

@jagoosw jagoosw commented Nov 14, 2023

No description provided.

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@jagoosw
Copy link
Collaborator Author

jagoosw commented Nov 14, 2023

I think I'll also move CPU testing and docs building to buildkite since it seems to be so much faster than GitHub actions

@navidcy
Copy link
Collaborator

navidcy commented Nov 14, 2023

Definitely. Go for it!

@navidcy
Copy link
Collaborator

navidcy commented Nov 14, 2023

Where do we set up the buildkite??

@navidcy
Copy link
Collaborator

navidcy commented Nov 14, 2023

if we'll have both CPU and GPU tests on buildkite then let's not call the buildkite pipeline gpu-tests

@jagoosw
Copy link
Collaborator Author

jagoosw commented Nov 14, 2023

Yeah I've changed the name now.

I'm not sure how oceananigans has it in the repo but I'm setting it up here https://buildkite.com/oceanbiome-dot-jl/oceanbiome. I'll add you to the org.

@jagoosw
Copy link
Collaborator Author

jagoosw commented Nov 14, 2023

Where do we set up the buildkite??

Also if you meant what is the host, we've now got a computer with an GPU that we can host the buildkite agent on.

@navidcy
Copy link
Collaborator

navidcy commented Nov 14, 2023

Where do we set up the buildkite??

Also if you meant what is the host, we've now got a computer with an GPU that we can host the buildkite agent on.

I was referring to any yml file we use to set up the buildkite pipeline?

@jagoosw
Copy link
Collaborator Author

jagoosw commented Nov 14, 2023

I think you should be able to edit it here https://buildkite.com/oceanbiome-dot-jl/oceanbiome/settings/steps

@jagoosw
Copy link
Collaborator Author

jagoosw commented Nov 14, 2023

Ah I just realised you can put it in the repo so I'll move it now I think you can add the config to the repo so I'll try now, but I'm not exactly sure how it works like that

.buildkite/pipeline.yml Outdated Show resolved Hide resolved
jagoosw and others added 2 commits November 14, 2023 23:00
@jagoosw jagoosw changed the title Minor GPU fixes and automatic testing (hopefully) (0.9.1) Move testing and docs to buildkite (+ minor GPU bug fix) Nov 14, 2023
@navidcy navidcy self-requested a review November 14, 2023 23:48
@navidcy
Copy link
Collaborator

navidcy commented Nov 14, 2023

Let's ensure that Documenter has been set using appropriate ssh keys and what not so that it has rights to push before we merge.

@jagoosw
Copy link
Collaborator Author

jagoosw commented Nov 14, 2023

Yeah definitely, I think it should be right now so hopefully it'll push a preview when it's done this time

@navidcy
Copy link
Collaborator

navidcy commented Nov 15, 2023

Let's ensure that Documenter has been set using appropriate ssh keys and what not so that it has rights to push before we merge.

https://buildkite.com/oceanbiome-dot-jl/oceanbiome/builds/45#018bd01c-23f7-4fb7-a411-83b6e3bde508/21-2823

@jagoosw
Copy link
Collaborator Author

jagoosw commented Nov 15, 2023

I think I've worked it out now, I had to make a new environmental variable on the agent I think

@navidcy
Copy link
Collaborator

navidcy commented Nov 15, 2023

Seems that it worked!

@jagoosw jagoosw merged commit e7d5d0d into main Nov 15, 2023
@jagoosw jagoosw deleted the jsw/auto-gpu-testing branch November 15, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants