-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs sections overhaul #441
Conversation
✅ Deploy Preview for obol-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not checked the links. We can play around with this version before merging once the pipelines are fixed (they make a temp deployment visible by everyone).
sidebar_position: 5 | ||
description: Claiming rewards from your DV using the Launchpad. | ||
--- | ||
# Claiming DV rewards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something went wrong here I think? This page is not related to claiming rewards, but a copy of monitoring.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a brand new page that we need to write. I went ahead and created it so at least it exists, so then we can fill it in later. There are many such pages that need creation or overhauling once this PR is complete...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we delete the monitoring part below then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yes, didn't realize that. Must have been a mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many such pages that need creation or overhauling once this PR is complete...
Define complete. Should I be expecting them to be complete before we merge this PR as complete? Or are we taking them out and merging in a dedicated PR when ready?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is just the new structure. This page is just a "placeholder" page that I've created. I removed the previous copy-paste that was left in by mistake. Currently the page just reads "This page is currently just a placeholder. Content coming soon."
|
||
# Use an existing beacon node | ||
|
||
You may have an existing beacon node and wish to use it to run as part of a DV cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this page supposed to be... only 1 sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous comment, this will be a brand new page, instead of having this information where it is currently at the bottom of the group quickstart as a selector tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is another placeholder page. Need to add more content.
86f703d
to
0d4ce1e
Compare
I added /next to all the redirects or else it didn't want to pass the test deployment check... this will need to be removed later...? |
Co-authored-by: Kaloyan Tanev <[email protected]>
Co-authored-by: Kaloyan Tanev <[email protected]>
Co-authored-by: Kaloyan Tanev <[email protected]>
Co-authored-by: Kaloyan Tanev <[email protected]>
Co-authored-by: Kaloyan Tanev <[email protected]>
Co-authored-by: Kaloyan Tanev <[email protected]>
fff2e6b
to
4a06043
Compare
Co-authored-by: Oisín Kyne <[email protected]>
Co-authored-by: Oisín Kyne <[email protected]>
Co-authored-by: Oisín Kyne <[email protected]>
Quality Gate failedFailed conditions |
Restructuring the docs sections in line with the plan as per the Notion page
https://www.notion.so/obol-dvt/Add-super-categories-115a7b296f45800cb201fc456109dbfe