Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs revamp #302

Closed
wants to merge 21 commits into from
Closed

Docs revamp #302

wants to merge 21 commits into from

Conversation

slugmann321
Copy link
Contributor

@slugmann321 slugmann321 commented Jan 29, 2024

Summary

Overhauling the docs to improve the flow for users. (Simplifying the quick start guides, removing duplicate information, reducing "sections within sections", etc.)

Details

Working out of this to-do list
https://docs.google.com/document/d/1H-K_zKSZNMwK45p4_udEJkTxSzSUN8siJvuYg7Dq7gA/edit

ticket:

@slugmann321 slugmann321 self-assigned this Jan 29, 2024
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for obol-docs failed.

Name Link
🔨 Latest commit b214b1d
🔍 Latest deploy log https://app.netlify.com/sites/obol-docs/deploys/65ccb28037f47100086333be

“Max added 2 commits January 29, 2024 15:40
…fault, and that the network can be changed with the .env.sample file.

This should go live on Feb 6th, at the same time that we change CDVN to Holesky by default.
@slugmann321 slugmann321 changed the title Just testing out the commit flow Max's docs edits Feb 5, 2024
@slugmann321 slugmann321 changed the title Max's docs edits Max's small docs edits Feb 5, 2024
@@ -20,7 +20,8 @@ Alternatively, the private key shares can be created in a lower-trust manner wit

## Pre-requisites

- Ensure you have [docker](https://docs.docker.com/engine/install/) installed.
- A basic [knowledge](https://docs.ethstaker.cc/ethstaker-knowledge-base/) of Ethereum nodes and validators.
- Ensure you have [docker](https://docs.docker.com/desktop/install/ubuntu/#install-docker-desktop) installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't have to be docker desktop, in fact most people will only have the engine installed and not the UI as they are not running a node with a UI framework installed

@@ -28,7 +28,8 @@ The default cluster consists of:

## Pre-requisites

- Ensure you have [docker](https://docs.docker.com/engine/install/) installed.
- A basic [knowledge](https://docs.ethstaker.cc/ethstaker-knowledge-base/) of Ethereum nodes and validators.
- Ensure you have [docker](https://docs.docker.com/desktop/install/ubuntu/#install-docker-desktop) installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@@ -13,7 +13,8 @@ The following instructions aim to assist a group of operators coordinating toget

## Pre-requisites

- Ensure you have [docker](https://docs.docker.com/engine/install/) installed.
- A basic [knowledge](https://docs.ethstaker.cc/ethstaker-knowledge-base/) of Ethereum nodes and validators.
- Ensure you have [docker](https://docs.docker.com/desktop/install/ubuntu/#install-docker-desktop) installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@@ -20,7 +20,8 @@ These roles hold no position of privilege in the cluster, they only set the init
The person creating the cluster <b>will</b> be a node operator in the cluster.<br /><br />
<h1>Pre-requisites</h1>
<ul>
<li>Ensure you have <a href="https://docs.docker.com/engine/install/" target="_blank">docker</a> installed.</li>
<li>A basic <a href="https://docs.ethstaker.cc/ethstaker-knowledge-base/" target="_blank">knowledge</a> of Ethereum nodes and validators.</li>
<li>Ensure you have <a href="https://docs.docker.com/desktop/install/ubuntu/#install-docker-desktop" target="_blank">docker</a> installed.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

- You have [enough up-to-spec nodes](../key-concepts.md#distributed-validator-threshold) for your mainnet deployment.
- Ensure you have [docker](https://docs.docker.com/engine/install/) installed on each node.
- Ensure you have [docker](https://docs.docker.com/desktop/install/linux-install/#generic-installation-steps) installed on each node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

<p align="center"><iframe width="560" height="315" src="https://www.youtube.com/embed/6pXASqjAQbs" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe></p>

## Pre-requisites

- Ensure you have [docker](https://docs.docker.com/engine/install/) installed.
- A basic [knowledge](https://docs.ethstaker.cc/ethstaker-knowledge-base/) of Ethereum nodes and validators.
- Ensure you have [docker](https://docs.docker.com/desktop/install/ubuntu/#install-docker-desktop) installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

The `charon-distributed-validator-node` repo is set by default to the Holesky testnet. If you wish to change the network, copy the file `.env.sample` inside the `charon-distributed-validator-node` folder, uncommenting line 5 and setting a value for `NETWORK`, saving the new file with the name `.env`.

.env.sample is a sample environment file that allows overriding default configuration defined in docker-compose.yml. Uncomment and set any variable to override its value.
:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but not sure it is in the right place. On this page before running the node is probably better? http://localhost:3000/docs/next/int/quickstart/group/quickstart-group-operator. As per the other conversation, this will only be relevant for the users using docker CDVN and should be under a tab moving forward

@slugmann321 slugmann321 changed the title Max's small docs edits Max's docs revamp Feb 13, 2024
@slugmann321 slugmann321 changed the title Max's docs revamp Docs revamp Feb 13, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants