Merge pull request #123 from timmyteo/chore/cleanup

Remove unused code and fix some errors
OWASP · Aug 31, 2023 · 5099a5c · 5099a5c
2 parents e26ec6f + 4cfa6ea
commit 5099a5c
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 12 deletions.
diff --git a/insecureinc/src/main/java/insecure/inc/Crypto.java b/insecureinc/src/main/java/insecure/inc/Crypto.java
@@ -11,16 +11,12 @@
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
 import java.util.Base64;
-import javax.crypto.spec.IvParameterSpec;
-import javax.crypto.spec.SecretKeySpec;
 
 /**
  * Handles Crypto functions
  */
 public class Crypto {
 	private static final String HASH_ALG="SHA-256";
-	private static SecretKeySpec key = null;
-	private static IvParameterSpec iv = null;
 	private static String masterSalt = "";
 
 	private static Crypto instance = null;

diff --git a/insecureinc/src/main/java/insecure/inc/Cwe434FileUpload.java b/insecureinc/src/main/java/insecure/inc/Cwe434FileUpload.java
@@ -81,7 +81,6 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
 	}
 
 	private String getFileName(final Part part) {
-	    final String partHeader = part.getHeader("content-disposition");
 	    for (String content : part.getHeader("content-disposition").split(";")) {
 	        if (content.trim().startsWith("filename")) {
 	            return content.substring(

diff --git a/insecureinc/src/main/java/insecure/inc/Cwe611FileUpload.java b/insecureinc/src/main/java/insecure/inc/Cwe611FileUpload.java
@@ -54,7 +54,6 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
 	}
 
 	private String getFileName(final Part part) {
-	    final String partHeader = part.getHeader("content-disposition");
 	    for (String content : part.getHeader("content-disposition").split(";")) {
 	        if (content.trim().startsWith("filename")) {
 	            return content.substring(

diff --git a/insecureinc/src/main/java/insecure/inc/EmbeddedDB.java b/insecureinc/src/main/java/insecure/inc/EmbeddedDB.java
@@ -10,7 +10,6 @@
 import java.sql.Driver;
 import java.sql.DriverManager;
 import java.sql.PreparedStatement;
-import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Statement;
 import java.util.Random;
@@ -26,7 +25,6 @@ public void createDB() {
 
 		  PreparedStatement pstmt;
 		  Statement stmt;
-		  ResultSet rs = null;
 		  String createSQL = "create table users (usr varchar(30), pwd varchar(30))";
 
 

diff --git a/insecureinc/src/main/java/insecure/inc/Util.java b/insecureinc/src/main/java/insecure/inc/Util.java
@@ -246,7 +246,6 @@ public static String executePwdProg(String userPwd,String sourceFile) throws IOE
 	    stdIn.flush();
 	    stdIn.close();
 	    p.waitFor();
-	    StringBuilder sb = new StringBuilder();
 
 	    if(p.exitValue() == 0){
 		   reader = new BufferedReader(new InputStreamReader(p.getInputStream()));

diff --git a/insecureinc/src/main/webapp/cwe352loggedin.jsp b/insecureinc/src/main/webapp/cwe352loggedin.jsp
@@ -79,7 +79,7 @@ function getProfile(){
     <ul class="nav navbar-nav">
       <li class="active"><a href="#">cwe352 - Cross-Site Request Forgery Guest</a></li>
       <!-- Hidden in the guest UI
-	  <li class="active"><a href="cwe352admin.jsp">CWE863 - Cross-Site Request Forgery Admin</a></li>
+	  <li class="active"><a href="cwe352admin.jsp">CWE352 - Cross-Site Request Forgery Admin</a></li>
 	   -->
     </ul>
   </div>

diff --git a/insecureinc/src/main/webapp/cwe79loggedin.jsp b/insecureinc/src/main/webapp/cwe79loggedin.jsp
@@ -102,7 +102,7 @@ function getProfile(){
     <ul class="nav navbar-nav">
       <li class="active"><a href="#">cwe79 - Cross-Site Scripting Guest</a></li>
       <!-- Hidden in the guest UI
-	  <li class="active"><a href="cwe79admin.jsp">CWE863 - Cross-Site Scripting Admin</a></li>
+	  <li class="active"><a href="cwe79admin.jsp">CWE79 - Cross-Site Scripting Admin</a></li>
 	   -->
     </ul>
   </div>

diff --git a/insecureinc/src/main/webapp/cwe862loggedin.jsp b/insecureinc/src/main/webapp/cwe862loggedin.jsp
@@ -28,7 +28,7 @@ else{
     <ul class="nav navbar-nav">
       <li class="active"><a href="#">CWE862 - Missing Authorization Guest</a></li>
       <!-- Hidden in the guest UI
-	  <li class="active"><a href="cwe862admin.jsp">CWE863 - Missing Authorization Admin</a></li>
+	  <li class="active"><a href="cwe862admin.jsp">CWE862 - Missing Authorization Admin</a></li>
 	   -->
     </ul>
     <ul class="nav navbar-nav navbar-right">