Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the README file to include the information the sim_vim_sig.py … #57

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Unique-Usman
Copy link
Contributor

@Unique-Usman Unique-Usman commented Mar 12, 2024

Describe the changes you have made in this PR

Added the information about sim_vim_sig.py and how to run the script.

A clear and concise description of what you want to happen

Checklist

  • Self-review of changed code
  • Added automated tests where applicable
  • Update Docs & Guides

@Unique-Usman
Copy link
Contributor Author

@etpeterson I added instruction on how to run sim_vim_sig.py for clearity.

Copy link
Contributor

@etpeterson etpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this. Just the single comment.


```sh
python sim_vim_sig.py [-h] [-b BVALUE [BVALUE ...] | -f FILE] [-n NOISE] [-m] [-i]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide an abbreviated version of this help in the scrip itself? Perhaps with a -h help argument or if the expected inputs aren't provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you meant this ?

Screenshot from 2024-03-12 21-43-29

It is automatically, created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, excellent.

@etpeterson etpeterson merged commit f72525e into OSIPI:main Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants