Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove INSTALL_NAME_DIR from target #68

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Remove INSTALL_NAME_DIR from target #68

merged 1 commit into from
Mar 24, 2024

Conversation

thbeu
Copy link
Contributor

@thbeu thbeu commented Nov 19, 2023

Closes #49.

@rouault
Copy link
Member

rouault commented Nov 19, 2023

I'm very confused by the MacOSX situation. In the PROJ project, in OSGeo/PROJ#3948, there's a pull request doing the exact reverse thing as your PR...

@thbeu
Copy link
Contributor Author

thbeu commented Nov 19, 2023

I am confused as well. I do not set INSTALL_NAME_DIR property in my other project and noticed #49.

@thbeu
Copy link
Contributor Author

thbeu commented Nov 19, 2023 •
edited
Loading

@mwoehlke-kitware Do you have any hint for a proper configuration? Thanks.

@thbeu
Copy link
Contributor Author

thbeu commented Mar 9, 2024

@russelltg Can you cross-check if it works on OSX? Thanks.

@thbeu
Copy link
Contributor Author

thbeu commented Mar 9, 2024

I'm very confused by the MacOSX situation. In the PROJ project, in OSGeo/PROJ#3948, there's a pull request doing the exact reverse thing as your PR...

That PROJ PR is now closed w/o merge.

@thbeu
Copy link
Contributor Author

thbeu commented Mar 9, 2024

I noticed the 1.6.0-0003-relocatable-shared-macos.patch of Conan to exactly fix that issue: https://github.com/conan-io/conan-center-index/pull/21894/files

@MaartenBent
Copy link

@MaartenBent What is you opinion?

I've never used INSTALL_NAME_DIR, or seen it used. So I have no suggestions.

@rouault rouault merged commit f04a4b3 into OSGeo:master Mar 24, 2024
6 checks passed
@thbeu thbeu deleted the remove-INSTALL_NAME_DIR branch March 24, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why is INSTALL_NAME_DIR set on the shp target?
3 participants
@thbeu @rouault @MaartenBent