Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual: fix broken HTML tags #4757

Merged
merged 1 commit into from
Nov 25, 2024
Merged

manual: fix broken HTML tags #4757

merged 1 commit into from
Nov 25, 2024

Conversation

neteler
Copy link
Member

@neteler neteler commented Nov 25, 2024

This PR fixes some broken HTML tags identified during a test run of adding HTML validation with super-linter.

See logs showing the errors at
https://github.com/echoix/grass/actions/runs/12001379426/job/33451802353?pr=303#step:4:8310

This PR fixes some broken HTML tags identified with a test run of the HTML validation with super-linter.

See
https://github.com/echoix/grass/actions/runs/12001379426/job/33451802353?pr=303#step:4:8310
@neteler neteler added manual Documentation related issues HTML Related code is in HTML docs labels Nov 25, 2024
@neteler neteler requested a review from echoix November 25, 2024 07:22
@neteler neteler self-assigned this Nov 25, 2024
@github-actions github-actions bot added vector Related to vector data processing raster Related to raster data processing temporal Related to temporal data processing module labels Nov 25, 2024
@neteler
Copy link
Member Author

neteler commented Nov 25, 2024

I don't know yet how to fix

  Error:  gui/wxpython/tplot/g.gui.tplot.html: SyntaxError: Unexpected closing tag "li". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (28:3)
  Error:    26 |     because these software packages use a reference date other than
  Error:    27 |     the UNIX Epoch time (00:00:00 UTC on 1 January 1970)).
  Error:  > 28 |   </li>
  Error:       |   ^^^^^
  Error:    29 | </ul>
  Error:    30 |
  Error:    31 | <div align="center" style="margin: 10px">

Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure: do the html entities for < and > work in pre-formatted blocks? Otherwise good to go!

@echoix
Copy link
Member

echoix commented Nov 25, 2024

I don't know yet how to fix

  Error:  gui/wxpython/tplot/g.gui.tplot.html: SyntaxError: Unexpected closing tag "li". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (28:3)

  Error:    26 |     because these software packages use a reference date other than

  Error:    27 |     the UNIX Epoch time (00:00:00 UTC on 1 January 1970)).

  Error:  > 28 |   </li>

  Error:       |   ^^^^^

  Error:    29 | </ul>

  Error:    30 |

  Error:    31 | <div align="center" style="margin: 10px">

Me neither. I think I left these ones in the grass-addons, as I didn't find what it was complaining about.

@echoix
Copy link
Member

echoix commented Nov 25, 2024

I invite you to test out the linter on your side, I think it may only the first parsing error of a file, so fixing the first ones might uncover some underneath that line.

@neteler
Copy link
Member Author

neteler commented Nov 25, 2024

Just to make sure: do the html entities for < and > work in pre-formatted blocks? Otherwise good to go!

Looks good:

image

@neteler
Copy link
Member Author

neteler commented Nov 25, 2024

I invite you to test out the linter on your side, I think it may only the first parsing error of a file, so fixing the first ones might uncover some underneath that line.

I see errors here but not sure:
https://validator.w3.org/check?uri=https%3A%2F%2Fgrass.osgeo.org%2Fgrass-stable%2Fmanuals%2Fg.gui.tplot.html&charset=%28detect+automatically%29&doctype=Inline&group=0

@neteler neteler added the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 25, 2024
@neteler neteler merged commit 63fc743 into OSGeo:main Nov 25, 2024
23 checks passed
@neteler neteler deleted the manual_fix_HTML branch November 25, 2024 20:51
neteler added a commit that referenced this pull request Nov 25, 2024
This PR fixes some broken HTML tags identified with a test run of the HTML validation with super-linter.

See logs showing the errors at:
https://github.com/echoix/grass/actions/runs/12001379426/job/33451802353?pr=303#step:4:8310
@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 25, 2024
@github-actions github-actions bot added this to the 8.5.0 milestone Nov 25, 2024
@neteler neteler modified the milestones: 8.5.0, 8.4.1 Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs HTML Related code is in HTML manual Documentation related issues module raster Related to raster data processing temporal Related to temporal data processing vector Related to vector data processing
Projects
Development

Successfully merging this pull request may close these issues.

2 participants