Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/grass/utils: fix checking server response content type/dispostion header to allow to download ZIP file. #4658

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Nov 5, 2024

Fixes #4657.

…tion header

To allow to download ZIP file.

Server response headers which indicating ZIP file:

content-type: application/octet-stream
content-disposition: attachment; filename=natural_earth_dataset.zip

Fix download Natural Earth Dataset in WGS84 from the server URL
https://zenodo.org/records/13370131/files/natural_earth_dataset.zip
@tmszi tmszi added bug Something isn't working GUI wxGUI related Python Related code is in Python backport to 8.4 PR needs to be backported to release branch 8.4 labels Nov 5, 2024
@tmszi tmszi added this to the 8.4.1 milestone Nov 5, 2024
@tmszi tmszi self-assigned this Nov 5, 2024
@tmszi tmszi merged commit 48e382c into OSGeo:main Nov 6, 2024
25 of 27 checks passed
@tmszi tmszi deleted the wxgui-locdownload-fix-download-natural-earth-dataset branch November 6, 2024 05:33
tmszi added a commit to tmszi/grass that referenced this pull request Nov 6, 2024
…ion header (OSGeo#4658)

To allow to download ZIP file.

Server response headers which indicating ZIP file:

content-type: application/octet-stream
content-disposition: attachment; filename=natural_earth_dataset.zip

Fix download Natural Earth Dataset in WGS84 from the server URL
https://zenodo.org/records/13370131/files/natural_earth_dataset.zip
@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 6, 2024
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Nov 11, 2024
…ion header (OSGeo#4658)

To allow to download ZIP file.

Server response headers which indicating ZIP file:

content-type: application/octet-stream
content-disposition: attachment; filename=natural_earth_dataset.zip

Fix download Natural Earth Dataset in WGS84 from the server URL
https://zenodo.org/records/13370131/files/natural_earth_dataset.zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related libraries Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Download Natural Earth Dataset in WGS84 prints error message
3 participants