Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db.out.ogr: Removed unused variable #4617

Merged
merged 2 commits into from
Oct 31, 2024
Merged

db.out.ogr: Removed unused variable #4617

merged 2 commits into from
Oct 31, 2024

Conversation

arohanajit
Copy link
Contributor

Fixed 841 by removing unused table

echoix
echoix reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unexpected, that a module's option isn't used at all

@github-actions github-actions bot added Python Related code is in Python database Related to database management module labels Oct 30, 2024
@petrasovaa
Copy link
Contributor

See #4242. For backwards compatibility we probably shouldn't remove an option, even though it's unused. Since the issue is tracked, I am fine with this PR.

petrasovaa
petrasovaa previously approved these changes Oct 30, 2024
View reviewed changes
echoix
echoix approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug filed to track that the option isn't used, so it's correct to have this merged

@echoix echoix merged commit d5a8722 into OSGeo:main Oct 31, 2024
26 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Oct 31, 2024
@a0x8o a0x8o mentioned this pull request Nov 6, 2024
Merged
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Nov 11, 2024
@arohanajit @a0x8o
db.out.ogr: Removed unused variable (OSGeo#4617)
a27787a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

@petrasovaa petrasovaa petrasovaa left review comments

Assignees
No one assigned
Labels
database Related to database management module Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arohanajit @petrasovaa @echoix