-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v.info: add json output for columns #4590
Conversation
Signed-off-by: Nishant Bansal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and it has a test for most of the functionality. Thanks!
Signed-off-by: Nishant Bansal <[email protected]>
Signed-off-by: Nishant Bansal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
Signed-off-by: Nishant Bansal <[email protected]>
Signed-off-by: Nishant Bansal <[email protected]>
As Lines 57 to 60 in 24469d8
may be moved down, before: Lines 95 to 96 in 24469d8
|
Signed-off-by: Nishant Bansal <[email protected]>
Looks good to me now. |
Could we move forward with this PR? Any suggestions are welcome. |
Looks like everything was addressed. I briefly tested it and looks good! Thank you @NishantBansal2003 ! |
Use parson to add json support to v.info for columns. The JSON output looks like as follows:
fixes: #4218