Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Flake8 F841 fixes in the wxpython directory part 2 #4253

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

mshukuno
Copy link
Contributor

Description

Flake8 F841 (local variable assigned to but never used) fixes in the gui/wxpython/dbmgr directory.

Motivation and context

Changes require resolving a part of Flake8 warnings that are currently ignored. The issue title and number as follows.

  • [Bug] Fix currently ignored Flake8 warnings #1522

How has this been tested?

The GUI worked fine when I briefly tested it.

Types of changes

Removed unused variables and lines to fix F841.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as before)

Checklist

  • PR title provides summary of the changes and starts with one of the pre-defined prefixes
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Aug 29, 2024
gui/wxpython/dbmgr/base.py Show resolved Hide resolved
gui/wxpython/dbmgr/sqlbuilder.py Show resolved Hide resolved
gui/wxpython/dbmgr/base.py Outdated Show resolved Hide resolved
@petrasovaa petrasovaa merged commit e132155 into OSGeo:main Sep 4, 2024
26 checks passed
@neteler neteler added this to the 8.5.0 milestone Sep 5, 2024
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Sep 5, 2024
@mshukuno mshukuno deleted the flake8-F841-wx-2 branch September 18, 2024 15:03
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants