d.labels: Fix buffer overflow issues in do_labels.c #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShubhamDesai
changed the title
|
Please consider using pre-commit, which will solve e.g. clang-format issues before going to the CIs. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lbartoletti
reviewed
Jul 13, 2024
nilason
reviewed
Jul 15, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lbartoletti
reviewed
Jul 15, 2024
Co-authored-by: Loïc Bartoletti <[email protected]>
nilason
requested changes
Jul 16, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nilason
requested changes
Jul 16, 2024
Co-authored-by: Nicklas Larsson <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>
nilason
approved these changes
Jul 26, 2024
Mahesh1998
pushed a commit
to Mahesh1998/grass
that referenced
this pull request
Sep 19, 2024
Addresses multiple warnings identified by cppcheck related to potential buffer overflow issues. Added field width specifiers to the sscanf calls to prevent buffer overflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses multiple warnings identified by cppcheck related to potential buffer overflow issues.
Issues:
sscanf(text, "%*s %s", buff);
sscanf(text, "%*s %s", buff);
sscanf(text, "%*s %s", buff);
sscanf(text, "%*s %s", buff);
if (sscanf(text, "%*s %s", font) != 1 || !strcmp(font, "standard"))
sscanf(text, "%*s %s", buff);
switch (sscanf(buf, "%s%s", word1, word2))
Changes Made:
Added field width specifiers to the sscanf calls to prevent buffer overflows.
The field width is one less than the buffer size.
buff[128] -> %127s
font[256] -> %255s
word1[50], word2[50] -> %49s