Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: new pansharpen test #3764

Closed
wants to merge 8 commits into from
Closed

Conversation

manan-T
Copy link

@manan-T manan-T commented Jun 3, 2024

No description provided.

@github-actions github-actions bot added Python Related code is in Python tests Related to Test Suite labels Jun 3, 2024
testsuite/test_pansharpen.py Show resolved Hide resolved
testsuite/test_pansharpen.py Show resolved Hide resolved
testsuite/test_pansharpen.py Show resolved Hide resolved
testsuite/test_pansharpen.py Show resolved Hide resolved
testsuite/test_pansharpen.py Outdated Show resolved Hide resolved
testsuite/tests/test_pansharpen.py Show resolved Hide resolved
testsuite/tests/test_pansharpen.py Show resolved Hide resolved
testsuite/tests/test_pansharpen.py Show resolved Hide resolved
testsuite/tests/test_pansharpen.py Show resolved Hide resolved
testsuite/tests/test_pansharpen.py Show resolved Hide resolved
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes and but it mockes everything. Actual test is missing. Did you run i.pansharpen locally to retrieve some values to see what the current code outputs?

@neteler neteler changed the title New pansharpen test testsuite: new pansharpen test Jun 6, 2024
@echoix
Copy link
Member

echoix commented Jun 14, 2024

What's the difference intended between this new PR and #3757?

In both PRs, the testsuite/tests/test_pansharpen.py files are the same.

Also, what is the intended difference between the testsuite/tests/test_pansharpen.py and testsuite/test_pansharpen.py?

Finally, tests for modules like this should be (according to the current layout) located in the same subfolder as the module, in this case something like:

scripts/i.pansharpen/testsuite for gunittest-based tests.
scripts/i.pansharpen/tests for tests that can be ran by pytest.

@veroandreo
Copy link
Contributor

I'd say we close both this and #3757. @manan-T is welcome to open a new PR addressing the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Related code is in Python tests Related to Test Suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants