style(shell): Address various shellcheck issues and formatting

.github/workflows/build_osgeo4w.sh

@@ -15,8 +15,9 @@ set -e
 test -d "$1" && cd "$1"
 
 export OSGEO4W_ROOT_MSYS=/c/OSGeo4W
-export SRC=$(pwd)
+SRC="$(pwd)"
+export SRC
 export UNITTEST=1
 
 # Build according to OSGeo4W recipe
-${SRC}/mswindows/osgeo4w/build_osgeo4w.sh
+"${SRC}"/mswindows/osgeo4w/build_osgeo4w.sh

.github/workflows/build_ubuntu-22.04.sh

@@ -19,10 +19,10 @@ fi
 # Adding -Werror to make's CFLAGS is a workaround for configuring with
 # an old version of configure, which issues compiler warnings and
 # errors out. This may be removed with upgraded configure.in file.
-makecmd="make"
-if [[ "$#" -ge 2 ]]; then
+makecmd=("make")
+if [[ $# -ge 2 ]]; then
     ARGS=("$@")
-    makecmd="make CFLAGS='$CFLAGS ${ARGS[@]:1}' CXXFLAGS='$CXXFLAGS ${ARGS[@]:1}'"
+    makecmd=("make" "CFLAGS=$CFLAGS ${ARGS[@]:1}" "CXXFLAGS=$CXXFLAGS ${ARGS[@]:1}")
 fi
 
 # non-existent variables as an errors
@@ -52,5 +52,5 @@ export INSTALL_PREFIX=$1
     --with-tiff \
     --with-zstd
 
-eval $makecmd
+"${makecmd[@]}"
 make install

.github/workflows/build_ubuntu-22.04_without_x.sh

@@ -19,9 +19,10 @@ fi
 # Adding -Werror to make's CFLAGS is a workaround for configuring with
 # an old version of configure, which issues compiler warnings and
 # errors out. This may be removed with upgraded configure.in file.
-makecmd="make"
-if [[ "$#" -eq 2 ]]; then
-    makecmd="make CFLAGS='$CFLAGS $2' CXXFLAGS='$CXXFLAGS $2'"
+makecmd=("make")
+if [[ $# -ge 2 ]]; then
+    ARGS=("$@")
+    makecmd=("make" "CFLAGS=$CFLAGS ${ARGS[@]:1}" "CXXFLAGS=$CXXFLAGS ${ARGS[@]:1}")
 fi
 
 # non-existent variables as an errors
@@ -50,5 +51,5 @@ export INSTALL_PREFIX=$1
     --without-openmp \
     --without-pthread
 
-eval $makecmd
+"${makecmd[@]}"
 make install

.github/workflows/macos_install.sh

@@ -18,7 +18,7 @@ CONFIGURE_FLAGS="\
   --with-bzlib-libs=${CONDA_PREFIX}/lib \
   --with-cairo \
   --with-cairo-includes=${CONDA_PREFIX}/include/cairo \
-  --with-cairo-ldflags="-lcairo" \
+  --with-cairo-ldflags=-lcairo \
   --with-cairo-libs=${CONDA_PREFIX}/lib \
   --with-cxx \
   --with-fftw-includes=${CONDA_PREFIX}/include \
@@ -33,7 +33,6 @@ CONFIGURE_FLAGS="\
   --with-libpng=${CONDA_PREFIX}/bin/libpng-config \
   --with-libs=${CONDA_PREFIX}/lib \
   --with-netcdf=${CONDA_PREFIX}/bin/nc-config \
-  --with-netcdf=${CONDA_PREFIX}/bin/nc-config \
   --with-nls \
   --with-opengl=aqua \
   --with-openmp \
@@ -46,7 +45,7 @@ CONFIGURE_FLAGS="\
   --with-proj-share=${CONDA_PREFIX}/share/proj \
   --with-readline \
   --with-readline-includes=${CONDA_PREFIX}/include/readline \
-  --with-readline-libs=${CONDA_PREFIX}/lib
+  --with-readline-libs=${CONDA_PREFIX}/lib \
   --with-sqlite \
   --with-sqlite-includes=${CONDA_PREFIX}/include \
   --with-sqlite-libs=${CONDA_PREFIX}/lib \
@@ -56,7 +55,7 @@ CONFIGURE_FLAGS="\
   --with-zstd-includes=${CONDA_PREFIX}/include \
   --with-zstd-libs=${CONDA_PREFIX}/lib \
   --without-mysql \
-  --without-x \
+  --without-x
 "
 
 export CFLAGS="-O2 -pipe -arch ${CONDA_ARCH} -DGL_SILENCE_DEPRECATION -Wall -Wextra -Wpedantic -Wvla"
@@ -66,7 +65,7 @@ export CPPFLAGS="-isystem${CONDA_PREFIX}/include"
 ./configure $CONFIGURE_FLAGS
 
 EXEMPT=""
-make -j$(sysctl -n hw.ncpu) CFLAGS="$CFLAGS -Werror $EXEMPT" \
-  CXXFLAGS="$CXXFLAGS -Werror $EXEMPT"
+make -j"$(sysctl -n hw.ncpu)" CFLAGS="$CFLAGS -Werror $EXEMPT" \
+    CXXFLAGS="$CXXFLAGS -Werror $EXEMPT"
 
 make install

.github/workflows/test_thorough.sh

@@ -4,9 +4,9 @@
 set -e
 
 grass --tmp-project XY --exec \
-    g.download.project url=https://grass.osgeo.org/sampledata/north_carolina/nc_spm_full_v2alpha2.tar.gz path=$HOME
+    g.download.project url=https://grass.osgeo.org/sampledata/north_carolina/nc_spm_full_v2alpha2.tar.gz path="$HOME"
 
 grass --tmp-project XY --exec \
     python3 -m grass.gunittest.main \
-    --grassdata $HOME --location nc_spm_full_v2alpha2 --location-type nc \
-    --min-success 100 $@
+    --grassdata "$HOME" --location nc_spm_full_v2alpha2 --location-type nc \
+    --min-success 100 "$@"

.travis/linux.install.sh

@@ -4,6 +4,6 @@
 set -e
 
 sudo apt-get update -y
-    sudo apt-get install -y wget git gawk findutils
-    xargs -a <(awk '! /^ *(#|$)/' ".github/workflows/apt.txt") -r -- \
-        sudo apt-get install -y --no-install-recommends --no-install-suggests
+sudo apt-get install -y wget git gawk findutils
+xargs -a <(awk '! /^ *(#|$)/' ".github/workflows/apt.txt") -r -- \
+    sudo apt-get install -y --no-install-recommends --no-install-suggests

.travis/linux.script.sh

@@ -10,29 +10,29 @@ export MAKEFLAGS="-j $(nproc) --no-keep-going"
 echo "MAKEFLAGS is '$MAKEFLAGS'"
 
 ./configure --host=x86_64-linux-gnu \
-            --build=x86_64-linux-gnu \
-            --enable-largefile \
-            --enable-shared \
-            --prefix=/usr/lib \
-            --sharedstatedir=/var \
-            --sysconfdir=/etc \
-            --with-blas \
-            --with-cairo \
-            --with-cxx \
-            --with-freetype \
-            --with-freetype-includes=/usr/include/freetype2/ \
-            --with-gdal \
-            --with-geos \
-            --with-lapack \
-            --with-netcdf \
-            --with-nls \
-            --with-odbc \
-            --with-pdal \
-            --with-postgres \
-            --with-postgres-includes=/usr/include/postgresql/ \
-            --with-proj-share=/usr/share/proj \
-            --with-readline \
-            --with-sqlite \
-            --with-zstd
+    --build=x86_64-linux-gnu \
+    --enable-largefile \
+    --enable-shared \
+    --prefix=/usr/lib \
+    --sharedstatedir=/var \
+    --sysconfdir=/etc \
+    --with-blas \
+    --with-cairo \
+    --with-cxx \
+    --with-freetype \
+    --with-freetype-includes=/usr/include/freetype2/ \
+    --with-gdal \
+    --with-geos \
+    --with-lapack \
+    --with-netcdf \
+    --with-nls \
+    --with-odbc \
+    --with-pdal \
+    --with-postgres \
+    --with-postgres-includes=/usr/include/postgresql/ \
+    --with-proj-share=/usr/share/proj \
+    --with-readline \
+    --with-sqlite \
+    --with-zstd
 
 make CFLAGS="$CFLAGS $GRASS_EXTRA_CFLAGS" CXXFLAGS="$CXXFLAGS $GRASS_EXTRA_CXXFLAGS"

binder/postBuild

@@ -8,7 +8,8 @@ set -e
     --with-bzlib \
     --with-cairo \
     --with-cxx \
-    --with-freetype=yes --with-freetype-includes="/usr/include/freetype2/" \
+    --with-freetype-includes="/usr/include/freetype2/" \
+    --with-freetype=yes \
     --with-geos=/usr/bin/geos-config \
     --with-nls \
     --with-opengl-libs=/usr/include/GL \
@@ -20,13 +21,13 @@ make
 
 # put command on path
 # ensure the user specific bin dir exists (already on path)
-mkdir -p $HOME/.local/bin/
+mkdir -p "$HOME/.local/bin/"
 # create link to build
-ln -s $HOME/bin.*/grass* $HOME/.local/bin/grass
+ln -s "$HOME"/bin.*/grass* "$HOME/.local/bin/grass"
 
 # download a sample dataset
 mkdir -p data/grassdata \
-  && curl -SL https://grass.osgeo.org/sampledata/north_carolina/nc_basic_spm_grass7.zip > nc_basic_spm_grass7.zip \
-  && unzip -qq nc_basic_spm_grass7.zip \
-  && mv nc_basic_spm_grass7 data/grassdata \
-  && rm nc_basic_spm_grass7.zip
+    && curl -SL https://grass.osgeo.org/sampledata/north_carolina/nc_basic_spm_grass7.zip > nc_basic_spm_grass7.zip \
+    && unzip -qq nc_basic_spm_grass7.zip \
+    && mv nc_basic_spm_grass7 data/grassdata \
+    && rm nc_basic_spm_grass7.zip

docker/alpine/grass_tests.sh

@@ -1,4 +1,4 @@
-#/bin/bash
+#!/bin/bash
 
 # to be used in alpine Dockerfile
 
@@ -11,14 +11,14 @@ apk add --no-cache py3-scikit-learn
 grass --tmp-project EPSG:25832 --exec r.in.pdal input="/tmp/simple.laz" output="count_1" method="n" resolution=1 -g
 
 # Test GRASS GIS Python-addon installation
-grass --tmp-project XY --exec g.extension extension=r.learn.ml2 operation=add && \
-   grass --tmp-project XY --exec g.extension extension=r.learn.ml2 operation=remove -f
+grass --tmp-project XY --exec g.extension extension=r.learn.ml2 operation=add \
+    && grass --tmp-project XY --exec g.extension extension=r.learn.ml2 operation=remove -f
 
 # Test GRASS GIS C-addon installation: raster and vector
-grass --tmp-project XY --exec g.extension extension=r.gwr operation=add && \
-   grass --tmp-project XY --exec g.extension extension=r.gwr operation=remove -f
-grass --tmp-project XY --exec g.extension extension=v.centerpoint operation=add && \
-   grass --tmp-project XY --exec g.extension extension=v.centerpoint operation=remove -f
+grass --tmp-project XY --exec g.extension extension=r.gwr operation=add \
+    && grass --tmp-project XY --exec g.extension extension=r.gwr operation=remove -f
+grass --tmp-project XY --exec g.extension extension=v.centerpoint operation=add \
+    && grass --tmp-project XY --exec g.extension extension=v.centerpoint operation=remove -f
 
 # cleanup dependency
 apk del py3-scikit-learn

docker/testdata/test_docker_image.sh

@@ -36,31 +36,31 @@ grass --tmp-project EPSG:25832 --exec r.in.pdal input="/tmp/simple.laz" output="
 printf "\n############\nTesting GRASS GIS Python-addon installation:\n############\n"
 /usr/bin/python3 -m pip install --no-cache-dir scikit-learn
 
-grass --tmp-project XY --exec g.extension extension=r.learn.ml2 operation=add && \
-	   grass --tmp-project XY --exec g.extension extension=r.learn.ml2 operation=remove -f
+grass --tmp-project XY --exec g.extension extension=r.learn.ml2 operation=add \
+    && grass --tmp-project XY --exec g.extension extension=r.learn.ml2 operation=remove -f
 
 # cleanup dependency
 /usr/bin/python3 -m pip uninstall -y scikit-learn
 
 # Test GRASS GIS C-addon installation: raster and vector
 printf "\n############\nTesting GRASS GIS C-addon installation:\n############\n"
-grass --tmp-project XY --exec g.extension extension=r.gwr operation=add && \
-	   grass --tmp-project XY --exec g.extension extension=r.gwr operation=remove -f
-grass --tmp-project XY --exec g.extension extension=v.centerpoint operation=add && \
-	   grass --tmp-project XY --exec g.extension extension=v.centerpoint operation=remove -f
+grass --tmp-project XY --exec g.extension extension=r.gwr operation=add \
+    && grass --tmp-project XY --exec g.extension extension=r.gwr operation=remove -f
+grass --tmp-project XY --exec g.extension extension=v.centerpoint operation=add \
+    && grass --tmp-project XY --exec g.extension extension=v.centerpoint operation=remove -f
 
 # show GRASS GIS, PROJ, GDAL etc versions
 printf "\n############\nPrinting GRASS, PDAL and Python versions:\n############\n"
-grass --tmp-project EPSG:4326 --exec g.version -rge && \
-    pdal --version && \
-    python3 --version
+grass --tmp-project EPSG:4326 --exec g.version -rge \
+    && pdal --version \
+    && python3 --version
 
 # Test presence of central python packages
 printf "\n############\nPrinting versions of central python packages:\n############\n"
 python3 -c "import psycopg2;import numpy as np;print(psycopg2.__version__);print(np.__version__)"
 
 # Run testsuite
-if [ $TESTSUITE ] ; then
-  printf "\n############\nRunning the testsuite:\n############\n"
-  bash /grassdb/.github/workflows/test_thorough.sh
+if [ "$TESTSUITE" ]; then
+    printf "\n############\nRunning the testsuite:\n############\n"
+    bash /grassdb/.github/workflows/test_thorough.sh
 fi

general/g.parser/test.sh

@@ -25,27 +25,27 @@
 # % required: no
 # %end
 
-if [ -z "$GISBASE" ] ; then
+if [ -z "$GISBASE" ]; then
     echo "You must be in GRASS GIS to run this program." 1>&2
     exit 1
 fi
 
-if [ "$1" != "@ARGS_PARSED@" ] ; then
+if [ "$1" != "@ARGS_PARSED@" ]; then
     exec g.parser "$0" "$@"
 fi
 
 #### add your code below ####
 
 echo ""
 
-if [ $GIS_FLAG_F -eq 1 ] ; then
-  g.message message="Flag -f set"
+if [ "$GIS_FLAG_F" -eq 1 ]; then
+    g.message message="Flag -f set"
 else
-  g.message message="Flag -f not set"
+    g.message message="Flag -f not set"
 fi
 
 # test if parameter present:
-if [ -n "$GIS_OPT_OPTION1" ] ; then
+if [ -n "$GIS_OPT_OPTION1" ]; then
     echo "Value of GIS_OPT_OPTION1: '$GIS_OPT_OPTION1'"
 fi
 

gui/wxpython/core/testsuite/toolboxes.sh

@@ -1,7 +1,8 @@
+#!/usr/bin/env sh
 # Tests generating toolboxes XML
 
 # run make in gui/wxpython before the test
 # run test using sh -e
 
-python $GISBASE/gui/wxpython/core/toolboxes.py doctest
-python $GISBASE/gui/wxpython/core/toolboxes.py test
+python "$GISBASE/gui/wxpython/core/toolboxes.py" doctest
+python "$GISBASE/gui/wxpython/core/toolboxes.py" test