Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(deps): Update actions/checkout digest to b4ffde6 #3208

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 19, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/checkout action digest 8ade135 -> b4ffde6

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/actions-checkout-digest branch from 694d495 to 9def4de Compare October 22, 2023 12:29
@neteler neteler added the CI Continuous integration label Nov 4, 2023
@neteler neteler added this to the 8.4.0 milestone Nov 4, 2023
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b4ffde6 is actions/checkout latest release v4.1.1.

I wonder how to review these...one hash changing to another.

@wenzeslaus wenzeslaus merged commit 7c64bcf into main Nov 7, 2023
20 checks passed
@renovate renovate bot deleted the renovate/actions-checkout-digest branch November 7, 2023 17:31
@echoix
Copy link
Member

echoix commented Nov 7, 2023

b4ffde6 is actions/checkout latest release v4.1.1.

I wonder how to review these...one hash changing to another.

@wenzeslaus if we add more granularity to the comment, like # v4.1.1 I think renovate will keep the comment updated. I'm not able to refind the source for that, but renovate tried to keep the same granularity for Docker images, for example.

HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Jan 9, 2024
Update to release v4.1.1.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@neteler
Copy link
Member

neteler commented Jan 10, 2024

re backporting: I tried to cherry-pick 7c64bcf but it failed with a lot of merge conflicts.

@landam
Copy link
Member

landam commented Feb 9, 2024

Confirmed, there are plenty of conficts. Let's avoid backporting. @wenzeslaus Do you agree?

@wenzeslaus
Copy link
Member

I guess you would have to use Meld or similar procedure to get the changes there unless you follow (backport) every preceding change from main. I don't know why I added the backport label in November. Generally, I don't see how the automatic "renovations" would work for release branches unless 1) they are automated and 2) we are ready to make changes to the other source code if the need arises. Neither is fulfilled at this point. Maybe we were backporting these changes in the past...I do remember we had to backport things in CI when CI was broken, but that does not seem to be the case here. We also just deleted the problematic workflows on release branches in the past. Perhaps, it is on case-by-case basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants