-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contributing: Add branching how-to #2963
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Veronica Andreo <[email protected]>
Co-authored-by: Markus Neteler <[email protected]>
The commit cab12f1 does not add what it says it adds. The syntax fix is needed, but the information should go to:
|
We could just clean up the squash message instead of rebasing to achieve the same end goal. That needed change is in a comment suggestion by Markus Neteler, it just needs to be committed. After that, the PR should be ready. Having docs is better than no docs, and it's a snapshot of the (then) current knowledge of the workflow. If we find better ways in the future, it can be updated to follow along. Docs should be fast to merge, especially non end-user addressed ones like this one. |
Do you allow me to finish these two things up and merge? |
A fresh pair of eyes here would be great @echoix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote some comments weeks ago but stayed "pending" since I must have stopped before sending them
Co-authored-by: Markus Neteler <[email protected]>
This is now ready for review. Some information might be missing, but we may have a complete picture only after 8.4.0RC1 or even 8.4.0. |
This is now ready to be merged. Please, review. |
@veroandreo do you see more typos other than the ones I quickly spotted? |
Co-authored-by: Veronica Andreo <[email protected]> Co-authored-by: Markus Neteler <[email protected]>
Browsing this on phone (hence limited overview for me), I'd appreciate a hint in the text concerning the cronjob version bump which is needed, too. The binary build cronjobs are currently failing. |
And one more (to be done by @landam):
|
There's missing this, but aren't we better to have the currents docs than no updated docs at all (waiting for more than three months for that last edit, if ever we get to it). |
A document on how to create a new branch and what needs to be done around that. This complements the release how-to which is about creating releases (tags).