Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hungarian grids #127

Merged
merged 13 commits into from
Nov 8, 2024
Merged

Hungarian grids #127

merged 13 commits into from
Nov 8, 2024

Conversation

zsiki
Copy link
Contributor

@zsiki zsiki commented Oct 28, 2024

Dear Developers,

we have registered EPSG codes for Hungarian grids:

EPSG: 10668 Horizontal transformation
EPSG: 10666 Geoid model
EPSG: 10667 Reversible geoid model

This pull request adds our grids and updates proj-data pages.

Tanks,
Zoltan

@rouault
Copy link
Member

rouault commented Oct 28, 2024

I've noticed a discrepency on the licensing. In copyright_and_licenses.csv and hu_bme_README.txt, you mention Creative Commons Attribution 4.0 BY-SA but in the TIFFTAG_COPYRIGHT of the TIFF files, Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/ is mentionned.
They are not the same. The later (CC-BY-4.0) is less restrictive than (CC-BY-SA-4.0), because it doesn't have the share-alike clause. Both are fine for PROJ, you just need to decide which one.

Small remarks. In hu_bme_hd72corr.tif, the value of TIFFTAG_IMAGEDESCRIPTION is "HD72 (EPSG:4237) to ETRF2000 (EPSG:9067). Converted from ntv2_0.gsb". The " Converted from ntv2_0.gsb" is a bit weird since this is the name of the original Canadian NTV2 grid. I assume your source NTV2 file was named differently. The grid_name=XXX metadata item in the same file is also a bit weird. It would be best not to include it, although that's not a big deal.

@jjimenezshaw
Copy link
Contributor

Do you know that it has to be complemented with changes in https://github.com/OSGeo/PROJ/blob/master/data/sql/grid_alternatives.sql ? Otherwise PROJ will not recognize those files.

@rouault
Copy link
Member

rouault commented Nov 6, 2024

@zsiki gentle ping in case you didn't see our above messages

@zsiki
Copy link
Contributor Author

zsiki commented Nov 8, 2024

I've noticed a discrepency on the licensing. In copyright_and_licenses.csv and hu_bme_README.txt, you mention Creative Commons Attribution 4.0 BY-SA but in the TIFFTAG_COPYRIGHT of the TIFF files, Creative Commons Attribution 4.0 https://creativecommons.org/licenses/by/4.0/ is mentionned. They are not the same. The later (CC-BY-4.0) is less restrictive than (CC-BY-SA-4.0), because it doesn't have the share-alike clause. Both are fine for PROJ, you just need to decide which one.

Small remarks. In hu_bme_hd72corr.tif, the value of TIFFTAG_IMAGEDESCRIPTION is "HD72 (EPSG:4237) to ETRF2000 (EPSG:9067). Converted from ntv2_0.gsb". The " Converted from ntv2_0.gsb" is a bit weird since this is the name of the original Canadian NTV2 grid. I assume your source NTV2 file was named differently. The grid_name=XXX metadata item in the same file is also a bit weird. It would be best not to include it, although that's not a big deal.

I have corrected TIFFTAGs, I hope these are correct.

@zsiki
Copy link
Contributor Author

zsiki commented Nov 8, 2024

@zsiki gentle ping in case you didn't see our above messages

I've just added hu_bme grids to sql insert, sorry being late.

@rouault rouault added this to the 1.20 milestone Nov 8, 2024
@rouault rouault merged commit 2db0a99 into OSGeo:master Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants