Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACTIONX: mark GRUPTARG, GSATINJE, GSATPROD and TEST as unsupported #4400

Merged

Conversation

…s by ActionX since they are not supported by flow
@lisajulia
Copy link
Contributor Author

jenkins build this please

@blattms blattms changed the title Remove GRUPTARG, GSATINJE and GSATPROD from list of supported keyword… ACTIONX: mark GRUPTARG, GSATINJE and GSATPROD from as unsupported Jan 3, 2025
@blattms
Copy link
Member

blattms commented Jan 3, 2025

Nice catch. Thanks.

@blattms
Copy link
Member

blattms commented Jan 3, 2025

Was this needed for PYACTION?

The reason for asking is that there should already be an error for ACTIONX, at least once the action is evaluated. But maybe that is too late? What is the current behavior?

There is one small danger: If those keywords get supported then we might still miss them here.

@bska
Copy link
Member

bska commented Jan 6, 2025

For what it's worth all of these were added–by the original author–in PR #2677. Although not discussed in that PR, I do think that the intention was for these to be supported in ACTIONX mode.

@lisajulia
Copy link
Contributor Author

Was this needed for PYACTION?

The reason for asking is that there should already be an error for ACTIONX, at least once the action is evaluated. But maybe that is too late? What is the current behavior?

There is one small danger: If those keywords get supported then we might still miss them here.

This is not directly needed for PYACTION, yet my task here is to activate all keywords that are active for ACTIONX also for PYACTION.
In any case, if any of those keywords gets supported in the future, we should not just silently activate it for ACTIONX but add and only activate it afterwards.

@lisajulia
Copy link
Contributor Author

jenkins build this please

@lisajulia lisajulia changed the title ACTIONX: mark GRUPTARG, GSATINJE and GSATPROD from as unsupported ACTIONX: mark GRUPTARG, GSATINJE, GSATPROD and TEST as unsupported Jan 7, 2025
@blattms blattms merged commit 69d2b4d into OPM:master Jan 7, 2025
1 check passed
@lisajulia lisajulia deleted the cleanup/remove-unsupported-keywords-from-ActionX branch January 7, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants