Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gp: disable tests gp_50360, gp_50398, gp_50400, gp_50402, gp_50404 and gp_50406 #704

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

jforissier
Copy link
Contributor

Some tests for TEE_AllocateOperation() are invalid because they assume the function should reject non-zero maxKeySize values but the specification was clarified to explicitly allow them. Add a patch file to disable those tests.

@etienne-lms
Copy link
Contributor

It's strange the GP test suite does not comply with the GP spec :)

@jforissier
Copy link
Contributor Author

It's strange the GP test suite does not comply with the GP spec :)

I agree :) but I suppose the test suite was developed before the spec was clarified.

@etienne-lms
Copy link
Contributor

makes sense!

@etienne-lms
Copy link
Contributor

Acked-by: Etienne Carriere <[email protected]>

@vincent-mailhol
Copy link
Contributor

It's strange the GP test suite does not comply with the GP spec :)

Ask for a refund! More seriously, do you guys have a communication channel with the Global Platform committee? The only contact I found on their website is [email protected].

I agree :) but I suppose the test suite was developed before the spec was clarified.

Maybe it was developed before the spec update, but for sure, it was released after:

  • Test suite v2.0.0.2 is from June 2017 (ref).
  • TEE Internal Core API Specification Version 1.1.2 is from November 2016 (ref).

Regardless, Acked-by: Vincent Mailhol <[email protected]>.

Thank you.

…d gp_50406

Some tests for TEE_AllocateOperation() are invalid because they assume
the function should reject non-zero maxKeySize values but the
specification was clarified to explicitly allow them. Add a patch file
to disable those tests.

Signed-off-by: Jerome Forissier <[email protected]>
Acked-by: Etienne Carriere <[email protected]>
Acked-by: Vincent Mailhol <[email protected]>
@jforissier jforissier merged commit c6de693 into OP-TEE:master Nov 3, 2023
2 checks passed
@jforissier jforissier deleted the GP-TEE_AllocateOperation branch November 3, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants