Update help of xtest --stats #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Signed-off-by: tag is missing in the commit message.
I suggest to rephrase the message in describing what's done:
The command 'xtest --stats --time' is
notnow documented in the usage
description.
Acked-by: Etienne Carriere <[email protected]> once addressed.
jforissier
reviewed
Oct 17, 2023
There was a problem hiding this comment.
With my comment addressed:
Acked-by: Jerome Forissier <[email protected]>
host/xtest/stats.c
Outdated
| @@ -58,6 +58,7 @@ static int usage(void) | |||
| fprintf(stderr, " --alloc Print allocation statistics\n"); | |||
| fprintf(stderr, " --memleak Dump memory leak data on secure console\n"); | |||
| fprintf(stderr, " --ta Print loaded TAs context\n"); | |||
| fprintf(stderr, " --time Print system time\n"); | |||
JJayat
force-pushed
the
master
branch
2 times, most recently
from
12b42c6
to
4a39a73
Compare
etienne-lms
reviewed
Oct 18, 2023
The command 'xtest --stats --time' is now documented in the usage description. Acked-by: Etienne Carriere <[email protected]> Acked-by: Jerome Forissier <[email protected]> Signed-off-by: Julien Jayat <[email protected]>
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command 'xtest --stats --time' is not documented in the usage
description