Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtest: regression: add case 1040 #693

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

jenswi-linaro
Copy link
Contributor

Adds regression case 1040 to test panic in concurrent open/invoke/close session.

TEEC_Session session = { };
size_t n = 0;

while (n < 100) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to tune this value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the test level global level to tune that value (I understand one may want to increase this value).

@jenswi-linaro
Copy link
Contributor Author

This test case will fail without OP-TEE/optee_os#6281

}
n++;
}
return NULL;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicitly set a->res = TEE_SUCCESS to clarifies the test at line 3331?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

for (n = 0; n < nt; n++) {
if (!ADBG_EXPECT(c, 0, pthread_create(&arg[n].thr, NULL,
test_1040_thread,
arg + n)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation issue

@jenswi-linaro
Copy link
Contributor Author

Update

TEEC_Session session = { };
size_t n = 0;

while (n < 100) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the test level global level to tune that value (I understand one may want to increase this value).

ADBG_EXPECT_TEEC_SUCCESS(c, arg[n].res);
}
Do_ADBG_EndSubCase(c, "Concurent invoke with panic in TA");

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the empty line

@etienne-lms
Copy link
Contributor

Could you retrigger CI tests? OP-TEE/optee_os#6281 has been merged.

@jenswi-linaro
Copy link
Contributor Author

Update

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Etienne Carriere <[email protected]>

Adds regression case 1040 to test panic in concurrent open/invoke/close
session.

Signed-off-by: Jens Wiklander <[email protected]>
Reviewed-by: Etienne Carriere <[email protected]>
@jenswi-linaro
Copy link
Contributor Author

Squashed, rebased and tag applied.

@jforissier jforissier merged commit e1b6445 into OP-TEE:master Sep 27, 2023
1 check passed
@jenswi-linaro jenswi-linaro deleted the case-1040 branch September 27, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants