Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cellar url configurable from env and airflow #501

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Conversation

duprijil
Copy link
Collaborator

No description provided.

@duprijil duprijil self-assigned this Sep 29, 2023
ted_sws/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@CaptainOfHacks CaptainOfHacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise comments

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d39aff1) 94.76% compared to head (7b5d632) 94.76%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files         115      115           
  Lines        6114     6118    +4     
=======================================
+ Hits         5794     5798    +4     
  Misses        320      320           
Files Coverage Δ
...services/check_availability_of_notice_in_cellar.py 73.77% <100.00%> (+1.84%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duprijil duprijil merged commit 4870847 into main Sep 29, 2023
4 checks passed
@duprijil duprijil deleted the feature/TED4-21 branch September 29, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants