Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "ComponentFactory: Improve SymbolResolver creation (TEDEFO-3286)" #106

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

bertrand-lorentz
Copy link
Contributor

This reverts commit 9b8a7de. It introduced an infinite loop, causing a StackOverflowError.

This reverts commit 9b8a7de.
It introduced an infinite loop, causing a StackOverflowError.
Copy link
Contributor

@rouschr rouschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see it does the
return getSymbolResolver(sdkVersion, qualifier, sdkRootPath);
So indeed Java will pick the most precise signature in terms of passed types... so this cannot work unless the functions have different names

@bertrand-lorentz bertrand-lorentz merged commit 4059aed into develop Apr 19, 2024
1 check passed
@bertrand-lorentz bertrand-lorentz deleted the bugfix/fix-stackoverflow branch April 19, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants