TEDEFO-3325 added more debug logs which give insight into the package… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… detection and found classes related to the SdkComponent annotation.
rouschr
commented
May 2, 2024
src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentFactory.java
Show resolved
Hide resolved
rouschr
commented
May 2, 2024
src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentFactory.java
Outdated
Show resolved
Hide resolved
bertrand-lorentz
requested changes
May 2, 2024
src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentDescriptor.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentFactory.java
Outdated
Show resolved
Hide resolved
| Optional.ofNullable(componentsMap.get(normalizedVersion)) | ||
| .orElseGet(Collections::emptyMap); | ||
|
|
||
| if (logger.isDebugEnabled()) { |
There was a problem hiding this comment.
This should rather be done at the "trace" level.
There was a problem hiding this comment.
This has not been changed, it is still done at "debug" level".
| if (logger.isDebugEnabled()) { | ||
| logger.debug("selector componentType={}", selector.componentType); | ||
| logger.debug("selector qualifier={}", selector.qualifier); | ||
| logger.debug("normalized version={}", normalizedVersion); |
There was a problem hiding this comment.
Those 3 lines should be merged into one, with a clearer text.
And for other logs, those values are in square brackets, so let's be consistent.
So for example:
"Looking for component with version=[{}], componentType=[{}], qualifier=[{}]"
src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentFactory.java
Outdated
Show resolved
Hide resolved
|
Let me know if it is ok now |
bertrand-lorentz
requested changes
May 3, 2024
rouschr
deleted the
feature/TEDEFO-3325-improve-and-fix-core-reflection-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… detection and found classes related to the SdkComponent annotation.