TEDEFO-3325 addressing feedback to change from debug to trace and imp…

…roving the logs.
OP-TED · May 2, 2024 · 6eb4650 · 6eb4650
1 parent 4b26731
commit 6eb4650
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 16 deletions.
diff --git a/src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentDescriptor.java b/src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentDescriptor.java
@@ -50,7 +50,7 @@ public T createInstance(Object... initArgs) throws InstantiationException {
           .collect(Collectors.toList())
           .toArray(new Class[0]);
 
-      logger.debug("Creating an instance of [{}] using constructor with parameter types: {}",
+      logger.trace("Creating an instance of [{}] using constructor with parameter types: {}",
           implType, paramTypes);
 
       Constructor<T> constructor = Optional

diff --git a/src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentFactory.java b/src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentFactory.java
@@ -80,18 +80,10 @@ private void populateComponents() {
         .map(Package::getName)
         .toArray(String[]::new);
 
-    if (logger.isDebugEnabled()) {
+    if (logger.isTraceEnabled()) {
       final List<String> packages = Arrays.asList(availablePackages);
-
-      logger.debug("eforms eu packages:");
-      packages.stream().sorted()
-          .filter(p -> p.contains("eu.") && !p.contains("digit"))
-          .forEach(p -> logger.debug(p));
-
-      logger.debug("viewer package");
       packages.stream().sorted()
-          .filter(p -> p.contains("eu.europa.ted.eforms.viewer"))
-          .forEach(p -> logger.debug(p));
+          .forEach(p -> logger.trace(p));
     }
 
     new Reflections(ConfigurationBuilder.build().forPackages(availablePackages))
@@ -154,12 +146,12 @@ protected <T> T getComponentImpl(String sdkVersion, final SdkComponentType compo
             .orElseGet(Collections::emptyMap);
 
     if (logger.isDebugEnabled()) {
-      logger.debug("selector componentType={}", selector.componentType);
-      logger.debug("selector qualifier={}", selector.qualifier);
-      logger.debug("normalized version={}", normalizedVersion);
+      logger.debug("Looking for component with version=[{}], componentType=[{}], qualifier=[{}]",
+          normalizedVersion, selector.componentType, selector.qualifier);
       for (Entry<ComponentSelector, SdkComponentDescriptor<?>> entry : map.entrySet()) {
         logger.debug(
-            "entry key componentType={}, key qualifier={}, value={}",
+            "Available component for this version: "
+                + "componentType=[{}], qualifier=[{}], value=[{}]",
             entry.getKey().componentType,
             entry.getKey().qualifier,
             entry.getValue().getImplType().getName());
@@ -169,7 +161,6 @@ protected <T> T getComponentImpl(String sdkVersion, final SdkComponentType compo
     @SuppressWarnings("unchecked")
     SdkComponentDescriptor<T> descriptor =
         (SdkComponentDescriptor<T>) map.get(selector);
-    logger.debug("descriptor descriptor={}", descriptor);
 
     if (descriptor == null) {
       logger.error("Failed to load required components of SDK [{}]", sdkVersion);