-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release of eforms-SDK version 1.11.0 #849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrakaop
approved these changes
Mar 4, 2024
…into prepare/1.11.0
The new rules that check that those attributes are present cause problems in some apps, so remove them for now. They will be added back later.
Those new versions use Node.js 20, so this gets rid of the warning about Node.js 16 actions being deprecated.
Also update affected schematron files.
Also update corresponding schematron rules.
Remove constraints for notice subtype 22, and correct condition for subtype 14. Also update corresponding schematron rules.
Also update corresponding schematron rules.
This is just to align with the recent corrections in the schematron rules, and the removal of some rules on attributes.
Also update affected schematron rules, and correct one notice example to follow the corrected rule.
This reverts the changes from commit 5c29bbf, putting those constraints back to the situation as it was in SDK 1.10.0.
Also update corresponding Schematron rules.
This is just to align with the recent corrections in the schematron rules, and just adds and removes fired rules on valid notices.
Add description for 174 OPP-... and OPT-... fields, in all languages.
Also update rule messages where this name is used.
The rule is currently not in place, but let's correct the field name for OPT-310-Tender in its message anyways.
The new rules that check that the "listName" attribute is present for fields "Unpublished Identifier" (BT-195(BT-XXX)...) can cause problems in some apps, so remove them for now. They will be added back later.
Also update affected schematron rules.
The previous text was too long. Also update the expression and rule texts where the name appears.
Correct forbidden/mandatory condition for field BT-1118-NoticeResult for contract modifications (subtypes 38 and 39). Update affected schematron rules, and corresponding rule messages translations.
This reflects a fixed typo in one rule test.
BT-09(b)-Procedure "Applicable cross-border law" was not displayrf when it was unpublished.
Remove numbering from two lines under section 3.1.8 Techniques for subtypes 4, 5, and 6.
pdonohoe
approved these changes
Apr 5, 2024
pdonohoe
previously approved these changes
Apr 5, 2024
Also update rule messages where this field name appears.
Updating Rules and codelists sections in Release Notes.
bertrand-lorentz
previously approved these changes
Apr 22, 2024
bertrand-lorentz
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.