Prepare SDK 1.6.3 #744
Merged
Prepare SDK 1.6.3 #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a predicate on @languageID prevents the EFX Toolkit from using a call to the "efx:preferred-language-text" function in the XPath it generates. As the TED website needs all languages and not only the preferred one, we add such predicates on all multilingual fields in the files it uses. (cherry picked from commit 7895c04)
(cherry picked from commit a12268b)
Remove redundant rule checking that preferred publication date is after the dispatch date. It is already enforced by rule BR-BT-00738-0053. Correct that rule to allow the preferred publication date (BT-738) to be equal to the dispatch date (BT-05). Update corresponding schematron rules, and translations of rule message. (cherry picked from commit 4c8fd0c)
Also remove corresponding schematron rules. (cherry picked from commit 9b01b3f)
Remove rules BR-BT-00262-0211, BR-BT-00262-0212, BR-BT-00262-0213, to allow any main nature (works, services, and supplies) for subsidized contracts. Also remove those rules from Schematron files. (cherry picked from commit 2005c29)
pdonohoe
approved these changes
Oct 31, 2023
ferrakaop
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the changes is the same as for 1.8.1, except there's one less change in the rules, as the rule to remove did not exist in SDK 1.6 and before.
Failing checks are expected: version 1.6.0 already had errors reported by the SDK analyzer.
I've run the compilation of all view templates locally with a hacked up SDK analyzer, and no errors were detected.