Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release of SDK 1.9.1 #734

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Prepare release of SDK 1.9.1 #734

merged 4 commits into from
Oct 23, 2023

Conversation

bertrand-lorentz
Copy link
Contributor

Only change is the removal of 3 asserts (TEDEFO-2627).

@bertrand-lorentz
fields: Remove 3 asserts for subsidized contracts (TEDEFO-2627)
2005c29 
Remove rules BR-BT-00262-0211, BR-BT-00262-0212, BR-BT-00262-0213, to
allow any main nature (works, services, and supplies) for subsidized
contracts.

Also remove those rules from Schematron files.

(cherry picked from commit a6d4ea3)
@bertrand-lorentz
Set version to 1.9.0 in pom.xml and fields.json
dad347c
@bertrand-lorentz
CHANGELOG: Update for SDK 1.9.1
36629af
rousso
rousso previously approved these changes Oct 23, 2023
View reviewed changes
YvesJo
YvesJo reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@YvesJo YvesJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we me. just a comment on the changelog description, however not blocking

CHANGELOG.md Outdated Show resolved Hide resolved
YvesJo
YvesJo previously approved these changes Oct 23, 2023
View reviewed changes
ferrakaop
ferrakaop suggested changes Oct 23, 2023
View reviewed changes
Copy link

@ferrakaop ferrakaop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase to:
"This release removes 3 rules BR-BT-00262-0211, BR-BT-00262-0212, and BR-BT-00262-0213 so there is no constraint on the nature (works, services or supplies) of subsidised contracts."

@bertrand-lorentz bertrand-lorentz dismissed stale reviews from YvesJo and rousso via 4acd170 October 23, 2023 13:56
@bertrand-lorentz bertrand-lorentz merged commit 967d5f2 into release/1.9.1 Oct 23, 2023
2 checks passed
@bertrand-lorentz bertrand-lorentz deleted the prepare/1.9.1 branch October 23, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrakaop ferrakaop ferrakaop approved these changes

@YvesJo YvesJo YvesJo approved these changes

@rousso rousso rousso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bertrand-lorentz @rousso @YvesJo @ferrakaop