Changes and corrections for SDK 1.10.0 #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the schematron files further based on the notice subtype the rules apply to, so that one pattern contains either rules that apply to one specific notice subtype, or rules that are not specific to a notice subtype. There is still one pattern per file. The files "complete-validation.sch" defines one phase for each subtype. Each phase references the corresponding patterns so that it has all the rules that must be applied to notices of that subtype: all patterns for the subtype, and all patterns not specific to a subtype. When validating a notice, if you use the phase corresponding to the subtype of the notice being validated, you will avoid executing the XPaths for all the rules that apply only to other subtypes. This reduces significantly the execution time for large notices, by a factor of 6 in some examples. This is backwards-compatible for existing usage of the Schematron: the loading mechanism is the same, and if no phase is defined when validating, all rules will be applied, as before. Update all validation reports. This adds the indication of the phase used, updates the pattern identifiers, and moves around fired-rule elements. No real impact on the result of validation.
Add translations.json file indicating asset type and language for each translation file. Add language-codes.xml to provide a correspondance between 2-letters and 3-letters language code. This is in XML so that it can be easily used from XPath or XSLT.
This was caused by duplicate rules, so also remove those rules from Schematron files. Update affected validation report, removing the corresponding fired rules.
|
The check failure is an issue in the SDK Analyzer, due to the addition of the translations index file. |
pdonohoe
previously approved these changes
Oct 3, 2023
rouschr
previously approved these changes
Oct 4, 2023
YvesJo
previously approved these changes
Oct 5, 2023
Also remove unnecessary comments in X01 and X02 notices.
bertrand-lorentz
dismissed stale reviews from YvesJo, rouschr, and pdonohoe
via
8001152
An index file was added in translations, the latest version of the analyzer is needed to handle it.
Also remove corresponding schematron rules, and updated affected validation report.
This adds ND-DirectAward where it was missing, as it is now repeatable.
Add new tailored codelist "revenue-allocation" used by this field. Also add corresponding schematron rules.
rouschr
previously approved these changes
Oct 12, 2023
|
Analyzer has been updated, and issues it detected have been resolved, and this was approved previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for the description.