Skip to content

Commit

Permalink
Merge pull request #808 from OP-TED/prepare/1.7.3
Browse files Browse the repository at this point in the history
Prepare release of SDK 1.7.3
  • Loading branch information
bertrand-lorentz authored Jan 30, 2024
2 parents 3063021 + 376e64b commit f587e45
Show file tree
Hide file tree
Showing 198 changed files with 5,696 additions and 5,384 deletions.
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
# SDK 1.7.3 Release Notes

This release brings the following corrections in the validation rules, making them more permissive:

* Remove rule BR-BT-00743-0100 that required "Electronic invoicing" (BT-743-Lot) to be set to "required".
* Remove ineffective rules for change notices to improve performance when validating notices with a large number of lots.

This release also includes updated translations and updated notice visualisation templates.

A comprehensive list of changes between SDK 1.7.2 and SDK 1.7.3 can be seen at <https://github.com/OP-TED/eForms-SDK/compare/1.7.2...1.7.3>

You can explore the changes between those versions at <https://docs.ted.europa.eu/eforms-sdk-explorer?base=1.7.2&version=1.7.3>

# SDK 1.7.2 Release Notes

This release brings the following corrections in the validation rules, making them more permissive:
Expand Down
11 changes: 1 addition & 10 deletions fields/fields.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"ublVersion" : "2.3",
"sdkVersion" : "eforms-sdk-1.7.2",
"sdkVersion" : "eforms-sdk-1.7.3",
"metadataDatabase" : {
"version" : "1.7.1",
"createdOn" : "2023-04-24T12:34:54"
Expand Down Expand Up @@ -19239,15 +19239,6 @@
"type" : "flat"
},
"severity" : "ERROR"
},
"assert" : {
"value" : "{ND-Root} ${TRUE}",
"severity" : "ERROR",
"constraints" : [ {
"value" : "{ND-LotTenderingTerms} ${(OPP-070-notice in ('7','8','9','10','11','12','13','14','15','16','17','18','19','20','21','22','38','39','40') and (BT-743-Lot == 'required')) or not(OPP-070-notice in ('7','8','9','10','11','12','13','14','15','16','17','18','19','20','21','22','38','39','40')) or not(BT-743-Lot is present)}",
"severity" : "ERROR",
"message" : "rule|text|BR-BT-00743-0100"
} ]
}
}, {
"id" : "BT-744-Lot",
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

<groupId>eu.europa.ted.eforms</groupId>
<artifactId>eforms-sdk</artifactId>
<version>1.7.2</version>
<version>1.7.3</version>
<packaging>jar</packaging>

<name>eForms SDK</name>
Expand Down Expand Up @@ -48,7 +48,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.build.outputTimestamp>2023-10-30T10:23:38Z</project.build.outputTimestamp>
<project.build.outputTimestamp>2024-01-24T14:34:15Z</project.build.outputTimestamp>

<version.eforms-sdk-analyzer>1.6.0-SNAPSHOT</version.eforms-sdk-analyzer>

Expand Down
1 change: 0 additions & 1 deletion schematrons/dynamic/validation-stage-5.sch
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
<assert id="BR-BT-00630-0150" role="ERROR" diagnostics="BT-630_d_-Lot" test="(cbc:EndDate/xs:date(text()) > ../../../../../../../cbc:IssueDate/xs:date(text())) or not((cbc:EndDate) and (../../../../../../../cbc:IssueDate))">rule|text|BR-BT-00630-0150</assert>
</rule>
<rule context="/*/cac:ProcurementProjectLot[cbc:ID/@schemeName='Lot']/cac:TenderingTerms">
<assert id="BR-BT-00743-0100" role="ERROR" diagnostics="BT-743-Lot" test="(../../ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:NoticeSubType/cbc:SubTypeCode/normalize-space(text()) = ('7','8','9','10','11','12','13','14','15','16','17','18','19','20','21','22','38','39','40') and (cac:ContractExecutionRequirement/cbc:ExecutionRequirementCode[@listName='einvoicing']/normalize-space(text()) = 'required')) or not(../../ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:NoticeSubType/cbc:SubTypeCode/normalize-space(text()) = ('7','8','9','10','11','12','13','14','15','16','17','18','19','20','21','22','38','39','40')) or not(cac:ContractExecutionRequirement/cbc:ExecutionRequirementCode[@listName='einvoicing'])">rule|text|BR-BT-00743-0100</assert>
<assert id="BR-OPT-00301-1400" role="ERROR" diagnostics="OPT-301-Lot-AddInfo" test="(((cac:AdditionalInformationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:Company/cac:PartyIdentification/cbc:ID) or (cac:AdditionalInformationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:TouchPoint/cac:PartyIdentification/cbc:ID))) or not(cac:AdditionalInformationParty/cac:PartyIdentification/cbc:ID)">rule|text|BR-OPT-00301-1400</assert>
<assert id="BR-OPT-00301-1402" role="ERROR" diagnostics="OPT-301-Lot-DocProvider" test="(((cac:DocumentProviderParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:Company/cac:PartyIdentification/cbc:ID) or (cac:DocumentProviderParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:TouchPoint/cac:PartyIdentification/cbc:ID))) or not(cac:DocumentProviderParty/cac:PartyIdentification/cbc:ID)">rule|text|BR-OPT-00301-1402</assert>
<assert id="BR-OPT-00301-1420" role="ERROR" diagnostics="OPT-301-Lot-TenderEval" test="(((cac:TenderEvaluationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:Company/cac:PartyIdentification/cbc:ID) or (cac:TenderEvaluationParty/cac:PartyIdentification/cbc:ID/normalize-space(text()) = /*/ext:UBLExtensions/ext:UBLExtension/ext:ExtensionContent/efext:EformsExtension/efac:Organizations/efac:Organization/efac:TouchPoint/cac:PartyIdentification/cbc:ID))) or not(cac:TenderEvaluationParty/cac:PartyIdentification/cbc:ID)">rule|text|BR-OPT-00301-1420</assert>
Expand Down
Loading

0 comments on commit f587e45

Please sign in to comment.