-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop old map #4005
Open
benfurber
wants to merge
13
commits into
ONEARMY:master
Choose a base branch
from
benfurber:feat/map/drop-old-map
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: drop old map #4005
+672
−1,667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfurber
added
the
Review allow-preview ✅
Has received manual check for malicious code and can be safely built for preview
label
Nov 14, 2024
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 18, 2024 16:42
b98e20e
to
dcbf45a
Compare
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 18, 2024 16:47
dcbf45a
to
a3099d4
Compare
onearmy-community-platform Run #6601
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/4005
|
Run status |
Passed #6601
|
Run duration | 05m 22s |
Commit |
be6a1dd52f: fix: map anchor opening pin
|
Committer | Ben Furber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
73
|
View all changes introduced in this branch ↗︎ |
10 tasks
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 20, 2024 13:40
a3099d4
to
cfda27a
Compare
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 20, 2024 13:44
cfda27a
to
d011652
Compare
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 21, 2024 15:31
d011652
to
4761818
Compare
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 21, 2024 15:48
e2da640
to
0049db1
Compare
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 26, 2024 10:16
0049db1
to
059e513
Compare
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 26, 2024 17:05
d6423ae
to
2f5cf3c
Compare
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 27, 2024 15:25
2f5cf3c
to
4ac84ca
Compare
benfurber
force-pushed
the
feat/map/drop-old-map
branch
from
November 28, 2024 13:36
4ac84ca
to
cfe1f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mod: Maps 🗺
Review allow-preview ✅
Has received manual check for malicious code and can be safely built for preview
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The new map was a very slow render and had a few little bugs.
What is the new behavior?
Fixes the speed issues (and bugs) to a point where the old map can be removed.