feat: create API for questions search #3996
Open
+254
−251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariojsnunes
reviewed
Nov 9, 2024
onim-at
force-pushed
the
3917-question-search-remix
branch
from
030f316
to
1a01427
Compare
onim-at
force-pushed
the
3917-question-search-remix
branch
from
1a01427
to
10f4d08
Compare
onim-at
commented
Nov 11, 2024
There was a problem hiding this comment.
this file is under a test folder because otherwise it would raise the following error:
Error: Vitest failed to access its internal state.
One of the following is possible:
- "vitest" is imported directly without running "vitest" command
- "vitest" is imported inside "globalSetup" (to fix this, use "setupFiles" instead, because "globalSetup" runs in a different context)
- Otherwise, it might be a Vitest bug. Please report it to https://github.com/vitest-dev/vitest/issues
There was a problem hiding this comment.
same as for research, here:
#3987 (comment)
these tests are no longer useful. can remove the file, but add some cypress tests.
onim-at
force-pushed
the
3917-question-search-remix
branch
from
10f4d08
to
c1f0579
Compare
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/3996
|
| Run status |
|
| Run duration | 05m 18s |
| Commit |
|
| Committer | Cosimo Chetta |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
79
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fetch questions via firestore
What is the new behavior?
Fetch questions via remix backend API
Does this PR introduce a breaking change?
Git Issues
Closes #3917
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.