-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add accordion for settings form #3988
base: master
Are you sure you want to change the base?
Feat: Add accordion for settings form #3988
Conversation
I'm still wondering about the expected behaviour of the on click of the dropdown.. Should the full header row be clickable or should that only happen on the collapse button itself? Also, would like some opinion on the flex icon for the password text 💪 I've updated the size of the icon, not sure if that's ok or not. I've checked where it's used and it seems to not have impact. I'll need to add tests for the changes, will check on that in the coming days. Thank you, |
Hey @joperafe, thanks for the contribution.
|
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Dropdown should be updated with new accordion style,
figma
Local screenshot:
Does this PR introduce a breaking change?
Git Issues
Closes #3786
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
development
channel.