Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accordion for settings form #3786

Open
benfurber opened this issue Jul 19, 2024 · 9 comments · May be fixed by #3988
Open

feat: add accordion for settings form #3786

benfurber opened this issue Jul 19, 2024 · 9 comments · May be fixed by #3988

Comments

@benfurber
Copy link
Member

Screenshot 2024-07-19 at 14 57 11

Description

Apply this new accordion style, to the two forms (ChangeEmailForm and ChangePasswordForm) in the account settings tab (AccountSettingsSection)

Details

Obvs the new component should be built in the component library (packages/components). For bonus points, it would be a chance to start putting whole form objects into the component library.

@ceconcarlsen
Copy link

@benfurber i`ll starting working on it, thanks

@domsantini
Copy link

Hey @ceconcarlsen ! Were you still working on this issue by chance? I just learned about this project and would love to start contributing. Happy to take this off your plate if you're busy.

@benfurber
Copy link
Member Author

Welcome @domsantini! :)

I'd say give @ceconcarlsen a day to get back to you. After that please do give it a go.

@domsantini
Copy link

Thanks so much @benfurber !! That sounds perfect.

@benfurber benfurber assigned domsantini and unassigned ceconcarlsen Aug 26, 2024
@domsantini
Copy link

Thank you, Ben! I’ll work on getting this done this week.

@benfurber
Copy link
Member Author

Hey @domsantini, how are you getting on?

@domsantini
Copy link

Hey @benfurber ! So sorry I haven't pushed any progress. I got something thrown on my plate and I've had to study for that. But I'm hoping to get back on this as soon as that's done.

You can unassign me for the time being if you'd like, just so someone else can come swoop the ticket.

@joperafe
Copy link

Hi there @benfurber could I work on this one?

@benfurber
Copy link
Member Author

Awesome, thanks @benfurber!

joperafe added a commit to joperafe/community-platform that referenced this issue Nov 5, 2024
joperafe added a commit to joperafe/community-platform that referenced this issue Nov 5, 2024
joperafe added a commit to joperafe/community-platform that referenced this issue Nov 5, 2024
@joperafe joperafe linked a pull request Nov 5, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: New / Under Discussion
Development

Successfully merging a pull request may close this issue.

4 participants