Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support change of reference format while indenting #94

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

bclement-ocp
Copy link
Contributor

We now use the current source format to indent each line.

Related cleanup: the indenter now uses an array rather than a list to represent the content of the file for performance.

Note: currently includes #93.

@bclement-ocp bclement-ocp added the ok to review As its name says label Oct 27, 2023
@bclement-ocp bclement-ocp requested a review from nberth October 27, 2023 12:45
Copy link
Collaborator

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what I could identify, the PR-specific changes seem fine. I think they can be merged once isolated from #93 .

We now use the current source format to indent each line.

Related cleanup: the indenter now uses an array rather than a list to
represent the content of the file for performance.
@bclement-ocp bclement-ocp force-pushed the mr-indent-format-change branch from 69e1ee3 to 48aa4ab Compare October 27, 2023 13:17
Copy link
Collaborator

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge once the CI terminates.

@bclement-ocp bclement-ocp merged commit f25f915 into OCamlPro:master Oct 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to review As its name says
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants